Add feature flag methods#167
Merged
Merged
Conversation
michaelklishin
approved these changes
Nov 8, 2020
Owner
|
I am not a fan of fake servers. We can test against the real thing easily. |
Owner
|
Thank you! |
michaelklishin
added a commit
that referenced
this pull request
Nov 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #166
Regarding the
go.modchanges:I bumped ginkgo and gomega to latest and then ran
go mod tidy.The integration test is written such that it will succeed for future RabbitMQ versions (potentially having no feature flags).
I'm happy to write some more unit tests spinning up a fake HTTP server?