Add UploadVhostDefinitions()#274
Merged
michaelklishin merged 2 commits intoJun 19, 2023
Merged
Conversation
Correspond to POST /api/definitions/vhost
michaelklishin
requested changes
Jun 10, 2023
michaelklishin
left a comment
michaelklishin
left a comment
Owner
There was a problem hiding this comment.
The newly added test fails on CI and locally. See ./bin/ci/before_build.sh.
Here are some details:
• [FAILED] [0.005 seconds]
RabbitMQ HTTP API client POST /api/definitions/vhost [It] should create queues and exchanges as specified in the definitions for vhost rabbit/hole
gopath/src/github.com/michaelklishin/rabbit-hole/rabbithole_test.go:4229
[FAILED] Expected
<string>:
to equal
<string>: rabbit/hole
In [It] at: /gopath/src/github.com/michaelklishin/rabbit-hole/rabbithole_test.go:4256 @ 06/11/23 00:31:52.43
------------------------------
Summarizing 1 Failure:
[FAIL] RabbitMQ HTTP API client POST /api/definitions/vhost [It] should create queues and exchanges as specified in the definitions for vhost rabbit/hole
gopath/src/github.com/michaelklishin/rabbit-hole/rabbithole_test.go:4256
Author
|
@michaelklishin The tests should be fixed now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correspond to
POST /api/definitions/vhost.Basically similar to
UploadDefinitions()but with specifying thevhost.