feat: add SerialReadError to errors in samps module#3
Merged
michealroberts merged 1 commit intomainfrom May 6, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new exception class, SerialReadError, to the samps module along with corresponding unit tests.
- Introduces the SerialReadError class in src/samps/errors.py.
- Adds unit tests in test/test_errors.py to verify its behavior.
- Updates src/samps/init.py to export the new error.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/test_errors.py | Unit tests to verify error inheritance and messages. |
| src/samps/errors.py | Implements the new SerialReadError exception class. |
| src/samps/init.py | Exports SerialReadError via the module’s public API. |
Comments suppressed due to low confidence (1)
test/test_errors.py:15
- [nitpick] The test class name 'TestSerialReadErrorError' appears redundant; consider renaming it to 'TestSerialReadError' for clarity.
class TestSerialReadErrorError(unittest.TestCase):
feat: add SerialReadError to errors in samps module
michealroberts
force-pushed
the
feature/errors/SerialReadError
branch
from
049c550 to
c6fd589
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add SerialReadError to errors in samps module