feat: add ReadTimeoutHandler to handlers in samps module#5
feat: add ReadTimeoutHandler to handlers in samps module#5michealroberts merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new ReadTimeoutHandler into the samps module along with a comprehensive set of tests validating its behavior.
- Adds the ReadTimeoutHandler class for managing read timeouts.
- Implements functionality to start, check expiration, reset the timer, and represent its state.
- Provides unit tests covering non-timeout, timeout, expiration, and reset cases.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/test_handlers.py | Adds unit tests validating the behavior of ReadTimeoutHandler. |
| src/samps/handlers.py | Implements the ReadTimeoutHandler with timeout logic and related utility methods. |
michealroberts
force-pushed
the
feature/handlers/ReadTimeoutHandler
branch
from
6702a13 to
29aa385
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new ReadTimeoutHandler for managing read timeouts in the samps module.
- Adds a ReadTimeoutHandler class in src/samps/handlers.py that computes timeouts in milliseconds.
- Provides comprehensive unit tests in test/test_handlers.py to verify the handler’s behavior.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/test_handlers.py | New tests to validate various timeout and reset scenarios. |
| src/samps/handlers.py | New ReadTimeoutHandler implementation with methods for timeout comparison and representation. |
michealroberts
force-pushed
the
feature/handlers/ReadTimeoutHandler
branch
2 times, most recently
from
8bea709 to
559a7e3
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a ReadTimeoutHandler to the samps module for managing read timeouts in serial communication. Key changes include the implementation of the ReadTimeoutHandler class with its associated methods and adding unit tests to verify its behavior.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/samps/handlers.py | Implements the ReadTimeoutHandler functionality |
| test/test_handlers.py | Provides unit tests to validate the handler |
feat: add ReadTimeoutHandler to handlers in samps module
michealroberts
force-pushed
the
feature/handlers/ReadTimeoutHandler
branch
from
559a7e3 to
4f3850f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new ReadTimeoutHandler in the samps module for managing read timeouts, accompanied by unit tests.
- Added ReadTimeoutHandler implementation in src/samps/handlers.py
- Created test cases for ReadTimeoutHandler functionality in test/test_handlers.py
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/samps/handlers.py | Added ReadTimeoutHandler class with timeout management methods |
| test/test_handlers.py | Provided unit tests to validate ReadTimeoutHandler behavior |
feat: add ReadTimeoutHandler to handlers in samps module