feat: add BaseInterface(Protocol) to base in samps module#77
Merged
michealroberts merged 1 commit intomainfrom Dec 16, 2025
Merged
feat: add BaseInterface(Protocol) to base in samps module#77michealroberts merged 1 commit intomainfrom
michealroberts merged 1 commit intomainfrom
Conversation
michealroberts
added
enhancement
There was a problem hiding this comment.
Pull request overview
This PR introduces a new BaseInterface protocol to the samps module, establishing a standardized interface for transport layer implementations. The protocol defines the contract that all transport classes must follow for device communication.
Key Changes:
- Adds a runtime-checkable Protocol class defining transport layer interface methods
- Includes synchronous and asynchronous context manager support
- Provides comprehensive documentation for all interface methods
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
michealroberts
force-pushed
the
feature/base/BaseInterface
branch
from
73c5f01 to
da348d8
Compare
feat: add BaseInterface(Protocol) to base in samps module
michealroberts
force-pushed
the
feature/base/BaseInterface
branch
from
da348d8 to
2dd594e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add BaseInterface(Protocol) to base in samps module