feat: add BaseProtocolReadError to errors in samps module#78
Merged
michealroberts merged 1 commit intomainfrom Dec 16, 2025
Merged
feat: add BaseProtocolReadError to errors in samps module#78michealroberts merged 1 commit intomainfrom
michealroberts merged 1 commit intomainfrom
Conversation
michealroberts
added
enhancement
There was a problem hiding this comment.
Pull request overview
This PR introduces a new exception class BaseProtocolReadError to the samps module's error hierarchy and exports it through the module's public API.
- Added
BaseProtocolReadErrorexception class inerrors.py - Exported the new exception through
__init__.py
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/samps/errors.py | Defines the new BaseProtocolReadError exception class with basic initialization |
| src/samps/init.py | Exports BaseProtocolReadError in the module's public API |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
feat: add BaseProtocolReadError to errors in samps module
michealroberts
force-pushed
the
feature/errors/BaseProtocolReadError
branch
from
68fc986 to
553d79a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add BaseProtocolReadError to errors in samps module