feat: add BaseProtocolTimeoutError to errors in samps module#79
Merged
michealroberts merged 1 commit intomainfrom Dec 16, 2025
Merged
Conversation
feat: add BaseProtocolTimeoutError to errors in samps module
michealroberts
added
enhancement
There was a problem hiding this comment.
Pull request overview
This PR adds a new exception class BaseProtocolTimeoutError to handle timeout errors in the base protocol layer. The change introduces a dedicated error type for protocol-level timeouts, separate from serial communication timeouts.
- Adds
BaseProtocolTimeoutErrorexception class to the errors module - Exports the new exception through the package's public API
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/samps/errors.py | Defines the new BaseProtocolTimeoutError exception class with standard exception initialization |
| src/samps/init.py | Exports BaseProtocolTimeoutError in imports and __all__ list for public API access |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add BaseProtocolTimeoutError to errors in samps module