Skip to content

New feature: Sound Effects #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
microbit-carlos opened this issue Jul 4, 2022 · 4 comments
Closed

New feature: Sound Effects #103

microbit-carlos opened this issue Jul 4, 2022 · 4 comments
Labels
enhancement New feature or request
Milestone
2.1.0-beta.1

Comments

@microbit-carlos
Copy link
Contributor

microbit-carlos commented Jul 4, 2022 •
edited
Loading

Proposal in the docs:
@microbit-carlos microbit-carlos added the enhancement New feature or request label Jul 4, 2022
@microbit-carlos microbit-carlos added this to the 2.1 milestone Jul 4, 2022
@microbit-carlos
Copy link
Contributor Author

@dpgeorge let me know if there is anything I can do to facilitate this.

@dpgeorge dpgeorge mentioned this issue Jul 10, 2022
Merged
@dpgeorge
Copy link
Collaborator

See #106 for an initial implementation. It's on the audio-sound-effect branch in this repo.

dpgeorge added a commit that referenced this issue Aug 19, 2022
@dpgeorge
codal_port/microbit_soundeffect: Add audio.SoundEffect class.
854658d 
As per issue #103 and PR #106.

Current limitations:
- can't play an iterable of SoundEffect objects
- if a sound effect is playing with wait=False and another one is started
  then the first one will be stopped immediately

Signed-off-by: Damien George <[email protected]>
dpgeorge added a commit that referenced this issue Aug 19, 2022
@dpgeorge
codal_port/microbit_soundeffect: Add audio.SoundEffect class.
9a5958b 
As per issue #103 and PR #106.

Current limitations:
- can't play an iterable of SoundEffect objects
- if a sound effect is playing with wait=False and another one is started
  then the first one will be stopped immediately

Signed-off-by: Damien George <[email protected]>
@dpgeorge
Copy link
Collaborator

Implemented in 9a5958b and 822b3c9

@microbit-carlos
Copy link
Contributor Author

Thanks Damien! I've created #110 to capture the Foundation task to create the predefined SoundEffects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.1.0-beta.1
Development

No branches or pull requests
2 participants
@dpgeorge @microbit-carlos