Skip to content

Comments

Fix backcompat parsing for geo property#202

Merged
Zegnat merged 1 commit intomicroformats:masterfrom
gRegorLove:issue195
May 2, 2020
Merged

Fix backcompat parsing for geo property#202
Zegnat merged 1 commit intomicroformats:masterfrom
gRegorLove:issue195

Conversation

@gRegorLove
Copy link
Member

@gRegorLove gRegorLove commented Aug 25, 2018

Fixes #195

@gRegorLove gRegorLove requested review from Zegnat and aaronpk August 25, 2018 22:11
@gRegorLove gRegorLove requested a review from dshanske April 15, 2020 05:59
@gRegorLove gRegorLove linked an issue Apr 25, 2020 that may be closed by this pull request
Fix backcompat parsing for geo property #195
Closed
@Zegnat
Copy link
Member

Zegnat commented May 2, 2020

According to the original issue #195 this tries to address one test, but I found two affected tests:

  1. ✅ hcard/single: name is dropped from geo, seems correct to me!
  2. ✅ hproduct/aggregate: name is dropped here from the nested h-review here too, which also seems correct to me. Looks like the change to implied name for backcompat was overall positive!

LGTM 🚀

@Zegnat Zegnat merged commit daf09fb into microformats:master May 2, 2020
@gRegorLove gRegorLove deleted the issue195 branch July 8, 2022 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zegnat Zegnat Zegnat approved these changes

@dshanske dshanske dshanske approved these changes

@aaronpk aaronpk Awaiting requested review from aaronpk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix backcompat parsing for geo property

3 participants

@gRegorLove @Zegnat @dshanske