Skip to content

FIDO: Handle test-of-user-presence-required in ctap1DeviceHasCredential #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mar-v-in merged 1 commit into from
Oct 30, 2022
Merged

FIDO: Handle test-of-user-presence-required in ctap1DeviceHasCredential #1807

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...services-fido-core/src/main/kotlin/org/microg/gms/fido/core/transport/TransportHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import kotlinx.coroutines.delay
import org.microg.gms.fido.core.*
import org.microg.gms.fido.core.protocol.*
import org.microg.gms.fido.core.protocol.msgs.*
import org.microg.gms.fido.core.transport.nfc.CtapNfcMessageStatusException
import org.microg.gms.fido.core.transport.usb.ctaphid.CtapHidMessageStatusException

abstract class TransportHandler(val transport: Transport, val callback: TransportHandlerCallback?) {
Expand All @@ -39,7 +40,9 @@ abstract class TransportHandler(val transport: Transport, val callback: Transpor
connection.runCommand(U2fAuthenticationCommand(0x07, challenge, application, descriptor.id))
return true
} catch (e: CtapHidMessageStatusException) {
return false
return e.status == 0x6985;
} catch (e: CtapNfcMessageStatusException) {
return e.status == 0x6985;
}
}

Expand Down