play-services-core: Theme improvements #2113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@mar-v-in did you had a chance to take a look at this PR? |
mar-v-in
reviewed
Jan 2, 2024
* Apply background color on status and navigation bar from API 23 * Drop ActionBar theme and switch to Toolbar which works better with theming Signed-off-by: Aayush Gupta <[email protected]> Change-Id: I82a0b00cf4d50e2ddf6739c730814f4ab3ab91c2
* Also use primary and accent color from system Signed-off-by: Aayush Gupta <[email protected]> Change-Id: Id0d2f0b4d990c99b9a930198e747cb78caa1c86c
Contributor
Author
|
Rebased on latest changes |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
Toolbarinstead of action bar theme which works better with theming