Skip to content

Conversation

@DaVinci9196
Copy link
Contributor

java.security.ProviderException: Failed to generate key pair.
at android.security.keystore2.AndroidKeyStoreKeyPairGeneratorSpi.generateKeyPairHelper(AndroidKeyStoreKeyPairGeneratorSpi.java:620)
at android.security.keystore2.AndroidKeyStoreKeyPairGeneratorSpi.generateKeyPair(AndroidKeyStoreKeyPairGeneratorSpi.java:545)
at java.security.KeyPairGenerator$Delegate.generateKeyPair(KeyPairGenerator.java:727)

@ale5000-git
Copy link
Member

ale5000-git commented Jan 10, 2025

@DaVinci9196
Look at this: https://github.com/microg/GmsCore/pull/2199/files
Apparently some devices fails when attestation challenge is set, I wonder if it make sense to do the same as in PR #2199 also in Play Integrity (retry without attestation challenge if it fails with ProviderException).

@DaVinci9196
Copy link
Contributor Author

@DaVinci9196 Look at this: https://github.com/microg/GmsCore/pull/2199/files Apparently some devices fails when attestation challenge is set, I wonder if it make sense to do the same as in PR #2199 also in Play Integrity (retry without attestation challenge if it fails with ProviderException).

Very good idea, thanks

@mar-v-in mar-v-in added this to the 0.3.7 milestone Mar 12, 2025
@mar-v-in mar-v-in added the 🔒 Integrity Play Integrity, SafetyNet, DroidGuard and ReCAPTCHA label Mar 12, 2025
@mar-v-in mar-v-in merged commit e6cbaec into microg:master Apr 14, 2025
1 check passed
@DaVinci9196 DaVinci9196 deleted the fix_pi_key_error branch April 16, 2025 11:57
@flamme-demon
Copy link

flamme-demon commented Apr 20, 2025

Hi, team,

Without any pressure, do you plan to release a version soon that will correct this behavior?
Thank you for your feedback and your work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔒 Integrity Play Integrity, SafetyNet, DroidGuard and ReCAPTCHA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants