Skip to content

FIDO: Fix hard-coded string "Change how to use your security key" #2755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mar-v-in merged 4 commits into from
Mar 12, 2025
Merged

FIDO: Fix hard-coded string "Change how to use your security key" #2755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2a3ccda
Update fido_nfc_transport_fragment.xml
lucasmz-dev Jan 22, 2025
d0db7af
Update fido_usb_transport_fragment.xml
lucasmz-dev Jan 22, 2025
badb5db
Update strings.xml
lucasmz-dev Jan 22, 2025
b7e9ae1
Update strings.xml
lucasmz-dev Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion play-services-fido/core/src/main/res/layout/fido_nfc_transport_fragment.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
android:layout_height="wrap_content"
android:minHeight="0dp"
android:onClick="@{onBackClick}"
android:text="Change how to use your security key"
android:text="@string/fido_transport_modify"
android:textSize="12sp" />
</LinearLayout>

Expand Down
2 changes: 1 addition & 1 deletion play-services-fido/core/src/main/res/layout/fido_usb_transport_fragment.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@
android:layout_height="wrap_content"
android:minHeight="0dp"
android:onClick="@{onBackClick}"
android:text="Change how to use your security key"
android:text="@string/fido_transport_modify"
android:textSize="12sp" />
</LinearLayout>

Expand Down
1 change: 1 addition & 0 deletions play-services-fido/core/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,5 @@
<string name="fido_pin_ok">OK</string>
<string name="fido_pin_cancel">Cancel</string>
<string name="fido_wrong_pin">Wrong PIN entered!</string>
<string name="fido_transport_modify">Change how to use your security key</string>
</resources>
Loading