Skip to content

Conversation

@sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Jan 7, 2026

This pull-request:

Google doesn't use JUnit 5 at all, and so we wouldn't have any way of testing/maintaining this. This may be worthwhile as a standalone library instead.

@sdelamo sdelamo added the relates-to: build label for issues related to the build file or CI label Jan 7, 2026
}
}

//kotlin {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep this line as it takes long time to figure out how to properly setup debug

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it back 4f3d61c

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
2 New Critical Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@sdelamo sdelamo merged commit a45c42b into 1.9.x Jan 8, 2026
6 of 7 checks passed
@sdelamo sdelamo deleted the junit4 branch January 8, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relates-to: build label for issues related to the build file or CI

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants