-
Notifications
You must be signed in to change notification settings - Fork 24
fix: device code fallback for macOS browser auth and cross-platform URL opening #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sellakumaran
merged 19 commits into
main
from
fix/macos-browser-auth-msal-credential-fallback
Mar 6, 2026
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
cbdfdba
fix: device code fallback for macOS browser auth and cross-platform U…
sellakumaran 6c8fe1d
fix: address PR review comments and handle Linux xdg_open_failed error
sellakumaran 4da9b55
fix: auto-fix public client flows, add requirements check to blueprin…
sellakumaran 3272376
fix: eliminate double auth on Linux, improve PS module error handling
sellakumaran 2eae60e
fix: add system requirement checks to all setup commands that use Gra…
sellakumaran 35bd6a0
Skip requirements on dry run; clarify browser fallback
sellakumaran f10f636
fix: skip requirements on dry run, self-correct missing PS modules in…
sellakumaran 1550c0e
fix: extract real JWT from Graph request headers; unify PS auth scope…
sellakumaran bae2765
fix: extract last stdout line as JWT token; add clean error for missi…
sellakumaran 5b58ab7
fix: unify PS token cache key in RemoveStale and DeployCommand; updat…
sellakumaran ed2ace6
fix: improve auth prompt UX and clarify custom permissions message
sellakumaran 4fd11c7
fix: retry blueprint SP lookup on Azure AD propagation delay
sellakumaran ba0e867
fix: fix admin consent polling via MSAL token with Application.Read.All
sellakumaran c1e2486
fix: fall back to MSAL when PS Connect-MgGraph fails on any platform
sellakumaran ac390bf
fix: address PR review comments - disposal, logging, exit handling, d…
sellakumaran 538f309
Merge with main.
sellakumaran 1867f3a
fix: address second round of PR review comments
sellakumaran 64b8c2d
chore: add CHANGELOG, NuGet release notes, and review process updates
sellakumaran cccd810
fix: address PR review comments - StringComparison, PSGallery, encodi…
sellakumaran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| # Changelog | ||
|
|
||
| All notable changes to this project will be documented in this file. | ||
|
|
||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/). | ||
|
|
||
| ## [Unreleased] | ||
|
|
||
| ### Fixed | ||
| - macOS/Linux: device code fallback when browser authentication is unavailable (#309) | ||
| - Linux: MSAL fallback when PowerShell `Connect-MgGraph` fails in non-TTY environments (#309) | ||
| - Admin consent polling no longer times out after 180s — blueprint service principal now resolved with correct MSAL token (#309) | ||
| - `ConfigFileNotFoundException` now derives from `FileNotFoundException` so existing catch sites continue to work (#309) | ||
|
|
||
| ## [1.1.0] - 2026-02 | ||
|
|
||
| ### Added | ||
| - Custom blueprint permissions configuration and management — configure any resource's OAuth2 grants and inheritable permissions via `a365.config.json` (#298) | ||
| - `setup requirements` subcommand with per-category checks: PowerShell modules, location, client app configuration, Frontier Program enrollment (#293) | ||
| - `setup permissions copilotstudio` subcommand for Power Platform `CopilotStudio.Copilots.Invoke` permission (#298) | ||
| - Persistent MSAL token cache to reduce repeated WAM login prompts on Windows (#261) | ||
| - Auto-detect endpoint name from project settings; globally unique names to prevent accidental collisions (#289) | ||
| - `.NET` runtime roll-forward — CLI now works on .NET 9 and later without reinstalling (#276) | ||
| - Mock tooling server MCP protocol compliance for Python and Node.js agents (#263) | ||
|
|
||
| ### Fixed | ||
| - Prevent `InternalServerError` loop when `--update-endpoint` fails on create (#304) | ||
| - Correct endpoint name derivation for `needsDeployment=false` scenarios (#296) | ||
| - Browser auth falls back to device code on macOS when WAM/browser is unavailable (#290) | ||
| - `PublishCommand` now returns non-zero exit code on all error paths (#266) | ||
| - Azure CLI Graph token cached across publish command Graph API calls (#267) | ||
| - PowerShell 5.1 install compatibility and macOS auth testability improvements (#292) | ||
| - MOS token cache timezone comparison bug in `TryGetCachedToken` (#278) | ||
| - Location config validated before endpoint registration and deletion (#281) | ||
| - `CustomClientAppId` correctly set in `BlueprintSubcommand` to fix inheritable permissions (#272) | ||
| - Endpoint names trimmed of trailing hyphens to comply with Azure Bot Service naming rules (#257) | ||
| - Python projects without `pyproject.toml` handled in `a365 deploy` (#253) | ||
|
|
||
| ## [1.0.0] - 2025-12 | ||
|
|
||
| ### Added | ||
| - `a365 setup blueprint` — creates and configures an Agent Identity Blueprint in Azure AD | ||
| - `a365 setup permissions mcp` / `bot` — configures OAuth2 grants and inheritable permissions | ||
| - `a365 deploy` — multi-platform deployment (`.NET`, `Node.js`, `Python`) with auto-detection | ||
| - `a365 config init` — initialize project configuration | ||
| - `a365 cleanup` — remove Azure resources and blueprint configuration | ||
| - Interactive browser authentication via MSAL with WAM on Windows | ||
| - Microsoft Graph operations using PowerShell `Microsoft.Graph` module | ||
| - Admin consent polling with automatic detection | ||
|
|
||
| [Unreleased]: https://github.com/microsoft/Agent365-devTools/compare/v1.1.0...HEAD | ||
| [1.1.0]: https://github.com/microsoft/Agent365-devTools/compare/v1.0.0...v1.1.0 | ||
| [1.0.0]: https://github.com/microsoft/Agent365-devTools/releases/tag/v1.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.