Bug: Both TelemetryChannels do not correctly handle AggregateException

[TimothyMothra]

If you are reporting bug/issue, please provide detailed Repro instructions.

Repro Steps

still investigating, don't have a repro yet

Breeze fixed their issues. Can test using this: https://badssl.com/

Actual Behavior

We aren't handling the AggregateException.
Instead, we log this message:

"Failed to send: One or more errors occurred.."

ApplicationInsights-dotnet/src/Microsoft.ApplicationInsights/Channel/InMemoryTransmitter.cs

Lines 136 to 144 in f181abb

	try
	{
	// send request
	this.Send(telemetryItems, timeout).Wait();
	}
	catch (Exception e)
	{
	CoreEventSource.Log.FailedToSend(e.Message);
	}

Send method returns a Task

ApplicationInsights-dotnet/src/Microsoft.ApplicationInsights/Channel/InMemoryTransmitter.cs

Line 151 in f181abb

private Task Send(IEnumerable<ITelemetry> telemetryItems, TimeSpan timeout)

Expected Behavior

We need to correctly handle the AggregateException.

Version Info

SDK Version : all
.NET Version : all
How Application was onboarded with SDK(VisualStudio/StatusMonitor/Azure Extension) :
OS : nuget
Hosting Info (IIS/Azure WebApps/ etc) : onprem

[TimothyMothra]

ServerTelemetryChannel has the same bug.

TranssmissionSender does not handle the AggregateException

ApplicationInsights-dotnet/src/ServerTelemetryChannel/Implementation/TransmissionSender.cs

Lines 154 to 163 in f181abb

	try
	{
	TelemetryChannelEventSource.Log.TransmissionSendStarted(acceptedTransmission.Id);
	responseContent = await acceptedTransmission.SendAsync().ConfigureAwait(false);
	}
	catch (Exception e)
	{
	exception = e;
	}
	finally

There is an if later that tries to handle HttpRequestException, but it's also not checking for AggregateException

ApplicationInsights-dotnet/src/ServerTelemetryChannel/Implementation/TransmissionSender.cs

Line 194 in f181abb

if (responseContent == null && exception is HttpRequestException)

[cijothomas]

@MS-TimothyMothra Great catch! We really want to log most accurate error message if things are not working well, and fixing this further improves supportability.
Can you confirm that this issue is not affecting reliability (we are still doing retries as expected), but only our logging, and hence suportability is affected?

[pharring]

@MS-TimothyMothra I don't think ServerTelemetryChannel has the bug because it does an await which unpacks the Exception.

[TimothyMothra]

@cijothomas No behavior is affected, we're only logging incorrect or incomplete exceptions