Make TelemetryConfiguration.EnableW3CCorrelation static

[lmolkova]

ApplicationInsights-dotnet/src/Microsoft.ApplicationInsights/Extensibility/TelemetryConfiguration.cs

Lines 185 to 201 in 521a84d

	set
	{
	this.enableW3c = value;
	ActivityExtensions.TryRun(() =>
	{
	if (this.enableW3c)
	{
	Activity.DefaultIdFormat = ActivityIdFormat.W3C;
	Activity.ForceDefaultIdFormat = true;
	}
	else
	{
	Activity.DefaultIdFormat = ActivityIdFormat.Hierarchical;
	Activity.ForceDefaultIdFormat = true;
	}
	});
	}

The setter deals with static properties on Activity and having two different instances of configuration with different settings is not possible.

So logically it should be static.

[lmolkova]

@cijothomas what do you think?

[cijothomas]

@lmolkova I guess we don't have any other neat option. I need to check how static properties behave when configured from AI.Config file.

Another option.
Completely remove this from TelemetryConfig, and have EnableW3C field on both RequestCollector and DependencyCollector. Similar to the current W3C enablement?

[cijothomas]

Alternate:
Remove this public setting from TelemetryConfiguration.
Make TelemetryConfiguration define a static ctro(), inside which it'll set format to W3C, if format is NOT enforced already.

For users deciding to turn it off, simply use Activity static methods.
Activity.Default = Hierrachical,
Activity.Enforce = true.

[cijothomas]

we ended with the following:

Removed the public setting from TelemetryConfiguration.
Make TelemetryConfiguration define a static ctor(), inside which it'll set format to W3C, if format is NOT enforced already.

For users deciding to turn it off, simply use Activity static methods.
Activity.Default = Hierrachical,
Activity.Enforce = true.