Skip to content

AAD: Misc changes #2317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TimothyMothra merged 6 commits into from
Jul 2, 2021
Merged

AAD: Misc changes #2317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9ce8137
initialize cache inside constructor
Jun 14, 2021
da48c90
remove todo. not pursing caching right now
Jun 30, 2021
e192a74
cleanup comment
Jul 1, 2021
80217e5
update changelog
Jul 1, 2021
07ac585
Merge branch 'develop' into tilee/aad_wip
Jul 1, 2021
6b76032
Update ReflectionCredentialEnvelope.cs
Jul 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion BASE/src/Microsoft.ApplicationInsights/Channel/Transmission.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,6 @@ protected virtual HttpRequestMessage CreateRequestMessage(Uri address, Stream co

if (this.CredentialEnvelope != null)
{
// TODO: NEED TO USE CACHING HERE
var authToken = this.CredentialEnvelope.GetToken();

if (authToken == default(AuthToken))
Expand Down
6 changes: 0 additions & 6 deletions ...verTelemetryChannel/Implementation/TransmissionPolicy/AuthenticationTransmissionPolicy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,6 @@ public void Dispose()
/// </summary>
/// <remarks>
/// AN EXPLANATION OF THE STATUS CODES:
/// - <see cref="ResponseStatusCodes.BadRequest"/>
/// "HTTP/1.1 400 Incorrect API was used - v2 API does not support authentication".
/// This indicates that the AI resource was configured for AAD, but SDK was not.
/// This is a configuration issue and is not recoverable from the client side.
/// IMPORTANT: We ignore this error and allow telemetry to be dropped.
/// Ingestion also uses HTTP 400 for invalid JSON and is indistinguishable from AAD errors.
/// - <see cref="ResponseStatusCodes.Unauthorized"/>
/// "HTTP/1.1 401 Unauthorized - please provide the valid authorization token".
/// This indicates that the authorization token was either absent, invalid, or expired.
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
# Changelog

## VNext


## Version 2.18.0-beta3
- [Enable the self diagnostics and fix a NullReferenceException bug](https://github.com/microsoft/ApplicationInsights-dotnet/pull/2302)
- AAD Breaking change: [CredentialEnvelope.GetToken() now returns type AuthToken instead of string. This is to expose the Expiration value with the token.](https://github.com/microsoft/ApplicationInsights-dotnet/pull/2306)

## Version 2.18.0-beta2
- Reduce technical debt: Use pattern matching
Expand Down