-
Notifications
You must be signed in to change notification settings - Fork 294
Tilee/examples #2339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Tilee/examples #2339
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
50194fc
move example projects to root. change to project reference
b738ab3
update packages
a1968d8
remove release config
ca181ec
rename projects
44b22a2
build definition for examples solution
f2ab72a
cleanup yml
9a5fb11
fix yml
2afd141
test fix for yml
de0ab30
test fix yml
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| # Syntax: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions | ||
| # .NET CLI: https://docs.microsoft.com/dotnet/core/tools/ | ||
| # Description: The purpose of this build is to verify that our example projects compile. | ||
|
|
||
| name: Examples Sanity Build | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ main, develop ] | ||
| pull_request: | ||
| branches: [ main, develop ] | ||
|
|
||
| jobs: | ||
| build-test: | ||
|
|
||
| runs-on: windows-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| - name: Setup .NET | ||
| uses: actions/setup-dotnet@v1 | ||
| with: | ||
| dotnet-version: 5.0.x | ||
|
|
||
| - name: Install dependencies | ||
| run: dotnet restore ./examples/Examples.sln | ||
|
|
||
| - name: Build | ||
| run: dotnet build ./examples/Examples.sln | ||
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
examples/WebApp.AspNetCore/Program.cs → examples/AspNetCoreWebApp/Program.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| namespace WebApp.AspNetCore | ||
| namespace AspNetCoreWebApp | ||
| { | ||
| using System; | ||
| using System.Collections.Generic; | ||
|
|
||
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
examples/WebApp.AspNetCore/Startup.cs → examples/AspNetCoreWebApp/Startup.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| namespace WebApp.AspNetCore | ||
| namespace AspNetCoreWebApp | ||
| { | ||
| using System; | ||
| using System.Collections.Generic; | ||
|
|
||
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
25 changes: 14 additions & 11 deletions
25
...e/BackgroundTasksWithHostedService.csproj → ...e/BackgroundTasksWithHostedService.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,24 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk.Web"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>netcoreapp2.2</TargetFramework> | ||
| <TargetFramework>net5.0</TargetFramework> | ||
| <AspNetCoreHostingModel>InProcess</AspNetCoreHostingModel> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. AspNetCoreHostingModel - this may not be needed.. |
||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.ApplicationInsights.WorkerService" Version="2.8.0-beta3" /> | ||
| <PackageReference Include="Microsoft.Extensions.Configuration.CommandLine" Version="2.2.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="2.2.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="2.2.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Hosting" Version="2.2.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" Version="2.2.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Logging" Version="2.2.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Logging.Configuration" Version="2.2.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Logging.Console" Version="2.2.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Logging.Debug" Version="2.2.0" /> | ||
| <ProjectReference Include="..\..\NETCORE\src\Microsoft.ApplicationInsights.WorkerService\Microsoft.ApplicationInsights.WorkerService.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Extensions.Configuration.CommandLine" Version="5.0.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="5.0.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="5.0.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Hosting" Version="5.0.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" Version="5.0.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Logging" Version="5.0.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Logging.Configuration" Version="5.0.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Logging.Console" Version="5.0.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Logging.Debug" Version="5.0.0" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>net5.0</TargetFramework> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\..\NETCORE\src\Microsoft.ApplicationInsights.WorkerService\Microsoft.ApplicationInsights.WorkerService.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
15 changes: 8 additions & 7 deletions
15
...ceSampleWithApplicationInsights/Worker.cs → examples/WorkerService/Worker.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk.Worker"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net5.0</TargetFramework> | ||
| <UserSecretsId>dotnet-WorkerServiceSampleWithApplicationInsights-E563FF63-73E2-4449-909F-BD093B43F6EF</UserSecretsId> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\..\NETCORE\src\Microsoft.ApplicationInsights.WorkerService\Microsoft.ApplicationInsights.WorkerService.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Extensions.Hosting" Version="5.0.0" /> | ||
| </ItemGroup> | ||
| </Project> |
File renamed without changes.
File renamed without changes.
25 changes: 0 additions & 25 deletions
25
...es/WorkerServiceSDK/BackgroundTasksWithHostedService/BackgroundTasksWithHostedService.sln
This file was deleted.
Oops, something went wrong.
15 changes: 0 additions & 15 deletions
15
...ndTasksWithHostedService/BackgroundTasksWithHostedService/MyCustomTelemetryInitializer.cs
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have main branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch. I’ll fix this