Skip to content

Conversation

@alsepkow
Copy link
Contributor

@alsepkow alsepkow commented Jan 9, 2026

This PR updates the tests to recognize an additional HLK requirement for SM6.9 double support as it remains optional for 6.9. 16-bit types, 64-bit integers, and wave ops are required for SM 6.9 so they are implied via the core requirement.

Also removes the priority '2' set on the wave op tests. P2 tests are skipped in our automation. These tests were originally being skipped as WARP did not yet support wave ops with long vectors.

Partially implements #7608 . The rest of the implementation will be handled in OS code.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff 496974907e2ac7666f8bc889287d174755703016 ff2ad962435ace02a2a21087103adaeda7e54014 -- tools/clang/unittests/HLSLExec/LongVectors.cpp
View the diff from clang-format here.
diff --git a/tools/clang/unittests/HLSLExec/LongVectors.cpp b/tools/clang/unittests/HLSLExec/LongVectors.cpp
index 43ef5ec4..db6258ed 100644
--- a/tools/clang/unittests/HLSLExec/LongVectors.cpp
+++ b/tools/clang/unittests/HLSLExec/LongVectors.cpp
@@ -1796,8 +1796,8 @@ using namespace LongVector;
   TEST_METHOD(Op##_##DataType) {                                               \
     BEGIN_TEST_METHOD_PROPERTIES()                                             \
     TEST_METHOD_PROPERTY(                                                      \
-      "Kits.Specification",                                                    \
-      "Device.Graphics.D3D12.DXILCore.ShaderModel69.DoublePrecision")          \
+        "Kits.Specification",                                                  \
+        "Device.Graphics.D3D12.DXILCore.ShaderModel69.DoublePrecision")        \
     END_TEST_METHOD_PROPERTIES()                                               \
     runTest<DataType, OpType::Op>();                                           \
   }
@@ -1806,8 +1806,8 @@ using namespace LongVector;
   TEST_METHOD(Op##_##DataType) {                                               \
     BEGIN_TEST_METHOD_PROPERTIES()                                             \
     TEST_METHOD_PROPERTY(                                                      \
-      "Kits.Specification",                                                    \
-      "Device.Graphics.D3D12.DXILCore.ShaderModel69.CoreRequirement")          \
+        "Kits.Specification",                                                  \
+        "Device.Graphics.D3D12.DXILCore.ShaderModel69.CoreRequirement")        \
     END_TEST_METHOD_PROPERTIES()                                               \
     runWaveOpTest<DataType, OpType::Op>();                                     \
   }
@@ -1816,8 +1816,8 @@ using namespace LongVector;
   TEST_METHOD(Op##_##DataType) {                                               \
     BEGIN_TEST_METHOD_PROPERTIES()                                             \
     TEST_METHOD_PROPERTY(                                                      \
-      "Kits.Specification",                                                    \
-      "Device.Graphics.D3D12.DXILCore.ShaderModel69.DoublePrecision")          \
+        "Kits.Specification",                                                  \
+        "Device.Graphics.D3D12.DXILCore.ShaderModel69.DoublePrecision")        \
     END_TEST_METHOD_PROPERTIES()                                               \
     runWaveOpTest<DataType, OpType::Op>();                                     \
   }
  • Check this box to apply formatting changes to this branch.

Copy link
Member

@hekota hekota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alsepkow alsepkow merged commit 33cdb85 into microsoft:main Jan 13, 2026
10 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants