-
Notifications
You must be signed in to change notification settings - Fork 827
SM 6.9 - Version info and basic release notes. #8053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
damyanp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions for layout of ReleaseNotes, but I think we do need to fix the version numbers in version.inc.
Co-authored-by: Damyan Pepper <[email protected]>
damyanp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to do some more wordsmithing at some point, but LGTM.
damyanp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, and it may apply to other things in here, but we should be describing user-visible changes to the release rather than implementation details (like tests and infrastructure).
Co-authored-by: Damyan Pepper <[email protected]>
…/DirectXShaderCompiler into user/alsepkow/Release69
tex3d
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This PR updates necessary version info for a release. Also adds bullet to the release notes. Will need to do a better review to get a collection of changes for the release notes as we didn't manage notes for changes as they went in this release.