feat(tree): Add missing package exports #26136
Closed
+28
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds missing exports of two types (ScopedSchemaName and InsertableObjectFromSchemaRecord) that are referenced by existing API exports from the tree package. These types appear in the return types of exported APIs like SchemaFactory.object() but were not previously exported, causing them to be inlined in API reports without being marked as exported.
- Exports
ScopedSchemaNametype used in SchemaFactory method return types - Exports
InsertableObjectFromSchemaRecordtype used in SchemaFactory method return types
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/dds/tree/src/index.ts | Adds exports for ScopedSchemaName and InsertableObjectFromSchemaRecord types |
| packages/dds/tree/api-report/tree.public.api.md | Auto-generated API report reflecting the new exports with export keyword |
| packages/dds/tree/api-report/tree.legacy.public.api.md | Auto-generated API report reflecting the new exports with export keyword |
| packages/dds/tree/api-report/tree.legacy.beta.api.md | Auto-generated API report reflecting the new exports with export keyword |
| packages/dds/tree/api-report/tree.beta.api.md | Auto-generated API report reflecting the new exports with export keyword |
| packages/dds/tree/api-report/tree.alpha.api.md | Auto-generated API report reflecting the new exports with export keyword |
| packages/framework/fluid-framework/api-report/fluid-framework.public.api.md | Auto-generated API report reflecting the new exports (re-exported from tree package) |
| packages/framework/fluid-framework/api-report/fluid-framework.legacy.public.api.md | Auto-generated API report reflecting the new exports plus unrelated sequence exports |
| packages/framework/fluid-framework/api-report/fluid-framework.legacy.beta.api.md | Auto-generated API report reflecting the new exports |
| packages/framework/fluid-framework/api-report/fluid-framework.beta.api.md | Auto-generated API report reflecting the new exports |
| packages/framework/fluid-framework/api-report/fluid-framework.alpha.api.md | Auto-generated API report reflecting the new exports |
| @@ -95,6 +95,7 @@ export { | |||
| type TreeView, | |||
| type TreeViewEvents, | |||
| SchemaFactory, | |||
| type ScopedSchemaName, | |||
Contributor
There was a problem hiding this comment.
both of these are already exported via src/internalTypes.ts
Contributor
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing exports of types that are referenced by existing API exports. It isn't immediately clear why API-Extractor doesn't complain about these. Note that the types end up being defined inline in the reports and are referenced but are not annotated as "exported".