Merged
Conversation
This PR also updates the PIA tool to handle AssemblyKeyFileAttribute and AssemblySignatureKeyAttribute
There was a problem hiding this comment.
Pull Request Overview
Updates the MS.VS package versions and extends the PIA tooling to recognize two new assembly attributes.
- Added mappings for
AssemblyKeyFileAttributeandAssemblySignatureKeyAttributein the PIA converter. - Bumped several
Microsoft.VisualStudio.*package versions in the build settings.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tools/MakePIAPortableTool/MakePIAPortableTool.cs | Add support for two new System.Reflection attributes in PIA tool |
| build/package_versions.settings.targets | Update Microsoft.VisualStudio package versions to new releases |
Comments suppressed due to low confidence (2)
src/tools/MakePIAPortableTool/MakePIAPortableTool.cs:43
- Add a unit or integration test to verify that the PIA tool correctly recognizes and processes AssemblyKeyFileAttribute and AssemblySignatureKeyAttribute.
{ "System.Reflection.AssemblyKeyFileAttribute", System_Runtime },
src/tools/MakePIAPortableTool/MakePIAPortableTool.cs:44
- Confirm that
AssemblySignatureKeyAttributeis a valid attribute in the targeted runtime; if the actual attribute is named differently (e.g.,AssemblyKeyNameAttribute), update this mapping accordingly.
{ "System.Reflection.AssemblySignatureKeyAttribute", System_Runtime },
gregg-miskelly
approved these changes
Jun 23, 2025
WardenGnaw
added a commit
that referenced
this pull request
Jun 24, 2025
This PR also updates the PIA tool to handle AssemblyKeyFileAttribute and AssemblySignatureKeyAttribute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the MS.VS packages to update the underlying version of message pack. It also updates the PIA tool to handle AssemblyKeyFileAttribute and AssemblySignatureKeyAttribute