-
Notifications
You must be signed in to change notification settings - Fork 50
Add RuntimeIdentifiers to each project. #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but @daalcant should confirm that this will cause the pipeline to publish correctly.
@scovetta @gfs I'm not sure why #213 is broken, but adding a runtime identifier via project properties shouldn't be necessary. We are using |
Documentation just for peace-of-mind: https://docs.microsoft.com/en-us/dotnet/core/deploying/ |
The problem is that the publish command is missing these flags |
Closed. See #218 instead. |
Reopening and converting to draft mode. Will attempt to resolve this and any remaining publishing issues in one PR to reduce the number of times I need to test release artifacts. |
Publishing using the PublishSingleFile property is increasing the total unpacked size of a release by 4.5-5x (from ~100 MB to ~500 MB). I believe this is because the .NET runtime is again being bundled with each project built by the solution. I have removed this property for the time being and we can reconsider it in the future (perhaps with a revised project structure). Leaving this PR in draft mode for a bit longer so I can test the binaries and resolve a couple more issues re: code signing and maintaining Linux file permissions. |
This PR adds RuntimeIdentifiers to each project to enable self-contained cross-project publishing.
From here:
More information in dotnet/sdk#10902.
This should fix #213.