Skip to content

Renames setting property #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 23, 2022
Merged

Renames setting property #181

merged 2 commits into from
Feb 23, 2022

Conversation

irvinesunday
Copy link
Contributor

This PR:

  • Renames the setting property UseRestrictionAnnotationsToGeneratePathsForComplexProperties to UseRestrictionAnnotationsToGenerateComplexPropertyPaths. The new name is more terse.

@irvinesunday irvinesunday requested a review from baywet February 23, 2022 00:08
@irvinesunday irvinesunday self-assigned this Feb 23, 2022
baywet
baywet requested changes Feb 23, 2022
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of use may I suggest require? This maps closer to the behavior

@irvinesunday irvinesunday merged commit 64572d8 into master Feb 23, 2022
@irvinesunday irvinesunday deleted the fix/is/rename-setting-property branch February 23, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@xuzhg xuzhg Awaiting requested review from xuzhg

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

Assignees

@irvinesunday irvinesunday

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irvinesunday @baywet