-
Notifications
You must be signed in to change notification settings - Fork 257
Make OpenAPI.NET library trim-compatible #1717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
d8eda7a
Make library trim-compatible
captainsafia 08718e1
Avoid using generic overload for all enum types
captainsafia 11466d7
Update PublicApi.Approved.txt
captainsafia a0b6f9d
Avoid binary compat break in CloneFromCopyConstructor
captainsafia 5b006b2
Add obsoletion attributes and fix CloneFromCopyConstructor
captainsafia 8ea0964
Add ReferenceType.Path and tests for display names
captainsafia 2128408
Guard ReferenceType consumption for ExternalResource
captainsafia bced7d5
Add trimming test project and fix warnings
captainsafia be1046d
Apply suggestions from code review
baywet 4cc030d
ci: adds trimming project to solution
baywet 74275b8
ci: adds readers project to trimming test project
baywet 7f7c54a
ci: adds missing trimming root assembly directive
baywet 06b54c3
Fix build, address feedback, and remove Readers from trim tests
captainsafia c117bc5
Rely on enum fields never being trimmed
captainsafia 35811cc
Address feedback
captainsafia 8267c40
Add back doc comment on M.O.Readers
captainsafia 6200767
Update test/Microsoft.OpenApi.Tests/Attributes/DisplayAttributeTests.cs
MaggieKimani1 47ad39d
Fix syntax error
MaggieKimani1 3f597ba
Merge branch 'vnext' into safia/trimmable
MaggieKimani1 321e20d
Use native AOT-friendly generic overload
MaggieKimani1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,145 @@ | ||
// Copyright (c) Microsoft Corporation. All rights reserved. | ||
// Licensed under the MIT license. | ||
|
||
#nullable enable | ||
|
||
namespace System.Diagnostics.CodeAnalysis | ||
captainsafia marked this conversation as resolved.
Show resolved
Hide resolved
|
||
{ | ||
#if !NET7_0_OR_GREATER | ||
/// <summary> | ||
/// Indicates that certain members on a specified <see cref="Type"/> are accessed dynamically, | ||
/// for example through <see cref="System.Reflection"/>. | ||
/// </summary> | ||
/// <remarks> | ||
/// This allows tools to understand which members are being accessed during the execution | ||
/// of a program. | ||
/// | ||
/// This attribute is valid on members whose type is <see cref="Type"/> or <see cref="string"/>. | ||
/// | ||
/// When this attribute is applied to a location of type <see cref="string"/>, the assumption is | ||
/// that the string represents a fully qualified type name. | ||
/// | ||
/// When this attribute is applied to a class, interface, or struct, the members specified | ||
/// can be accessed dynamically on <see cref="Type"/> instances returned from calling | ||
/// <see cref="object.GetType"/> on instances of that class, interface, or struct. | ||
/// | ||
/// If the attribute is applied to a method it's treated as a special case and it implies | ||
/// the attribute should be applied to the "this" parameter of the method. As such the attribute | ||
/// should only be used on instance methods of types assignable to System.Type (or string, but no methods | ||
/// will use it there). | ||
/// </remarks> | ||
[AttributeUsage( | ||
AttributeTargets.Field | AttributeTargets.ReturnValue | AttributeTargets.GenericParameter | | ||
AttributeTargets.Parameter | AttributeTargets.Property | AttributeTargets.Method | | ||
AttributeTargets.Class | AttributeTargets.Interface | AttributeTargets.Struct, | ||
Inherited = false)] | ||
internal sealed class DynamicallyAccessedMembersAttribute : Attribute | ||
{ | ||
/// <summary> | ||
/// Initializes a new instance of the <see cref="DynamicallyAccessedMembersAttribute"/> class | ||
/// with the specified member types. | ||
/// </summary> | ||
/// <param name="memberTypes">The types of members dynamically accessed.</param> | ||
public DynamicallyAccessedMembersAttribute(DynamicallyAccessedMemberTypes memberTypes) | ||
{ | ||
MemberTypes = memberTypes; | ||
} | ||
|
||
/// <summary> | ||
/// Gets the <see cref="DynamicallyAccessedMemberTypes"/> which specifies the type | ||
/// of members dynamically accessed. | ||
/// </summary> | ||
public DynamicallyAccessedMemberTypes MemberTypes { get; } | ||
} | ||
|
||
/// <summary> | ||
/// Specifies the types of members that are dynamically accessed. | ||
/// | ||
/// This enumeration has a <see cref="FlagsAttribute"/> attribute that allows a | ||
/// bitwise combination of its member values. | ||
/// </summary> | ||
[Flags] | ||
internal enum DynamicallyAccessedMemberTypes | ||
{ | ||
/// <summary> | ||
/// Specifies no members. | ||
/// </summary> | ||
None = 0, | ||
|
||
/// <summary> | ||
/// Specifies the default, parameterless public constructor. | ||
/// </summary> | ||
PublicParameterlessConstructor = 0x0001, | ||
|
||
/// <summary> | ||
/// Specifies all public constructors. | ||
/// </summary> | ||
PublicConstructors = 0x0002 | PublicParameterlessConstructor, | ||
|
||
/// <summary> | ||
/// Specifies all non-public constructors. | ||
/// </summary> | ||
NonPublicConstructors = 0x0004, | ||
|
||
/// <summary> | ||
/// Specifies all public methods. | ||
/// </summary> | ||
PublicMethods = 0x0008, | ||
|
||
/// <summary> | ||
/// Specifies all non-public methods. | ||
/// </summary> | ||
NonPublicMethods = 0x0010, | ||
|
||
/// <summary> | ||
/// Specifies all public fields. | ||
/// </summary> | ||
PublicFields = 0x0020, | ||
|
||
/// <summary> | ||
/// Specifies all non-public fields. | ||
/// </summary> | ||
NonPublicFields = 0x0040, | ||
|
||
/// <summary> | ||
/// Specifies all public nested types. | ||
/// </summary> | ||
PublicNestedTypes = 0x0080, | ||
|
||
/// <summary> | ||
/// Specifies all non-public nested types. | ||
/// </summary> | ||
NonPublicNestedTypes = 0x0100, | ||
|
||
/// <summary> | ||
/// Specifies all public properties. | ||
/// </summary> | ||
PublicProperties = 0x0200, | ||
|
||
/// <summary> | ||
/// Specifies all non-public properties. | ||
/// </summary> | ||
NonPublicProperties = 0x0400, | ||
|
||
/// <summary> | ||
/// Specifies all public events. | ||
/// </summary> | ||
PublicEvents = 0x0800, | ||
|
||
/// <summary> | ||
/// Specifies all non-public events. | ||
/// </summary> | ||
NonPublicEvents = 0x1000, | ||
|
||
/// <summary> | ||
/// Specifies all interfaces implemented by the type. | ||
/// </summary> | ||
Interfaces = 0x2000, | ||
|
||
/// <summary> | ||
/// Specifies all members. | ||
/// </summary> | ||
All = ~None | ||
} | ||
#endif | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.