Skip to content

Conversation

@baywet
Copy link
Member

@baywet baywet commented Aug 28, 2024

No description provided.

@baywet baywet requested a review from darrelmiller as a code owner August 28, 2024 14:55
@baywet baywet self-assigned this Aug 28, 2024
@baywet baywet enabled auto-merge August 28, 2024 14:55
darrelmiller
darrelmiller previously approved these changes Aug 30, 2024
Copy link
Member

@darrelmiller darrelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but I do want to understand why we have a dependency on the Microsoft.VisualStudio.Threading library

@baywet
Copy link
Member Author

baywet commented Aug 30, 2024

Approving but I do want to understand why we have a dependency on the Microsoft.VisualStudio.Threading library

@darrelmiller this dependency brings the analyzers as well as a bunch of helpful Task management feature. Especially JoinedTaskFactory.Run which is much better than GetAwaiter().GetResult(). Once we fix the Task mess we'll be able to add just the analyzer

@baywet baywet force-pushed the chore/tasks-linting branch from 0294000 to 43f6a5e Compare September 4, 2024 16:07
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2024

@baywet
Copy link
Member Author

baywet commented Sep 4, 2024

Approving but I do want to understand why we have a dependency on the Microsoft.VisualStudio.Threading library

disregard my last comment, I had added a dependency on the wrong package. The new dependency is private and does not impact downstream packages.

@baywet baywet merged commit 7ad6b26 into main Sep 4, 2024
@baywet baywet deleted the chore/tasks-linting branch September 4, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants