-
Notifications
You must be signed in to change notification settings - Fork 12
Remove upper bound on System.Text.Json package reference #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cfd5a3b
Remove upper bound on System.Text.Json package reference
stephentoub 57057e1
Update src/lib/apimanifest.csproj
stephentoub b0a33d7
Merge branch 'main' into patch-1
baywet d901c19
Revert "Update src/lib/apimanifest.csproj"
baywet aeb87ee
fix: adds vulnerability suppression
baywet 36d24fd
chore: bumps patch version
baywet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this prevent people from testing applications using .NET 10 previews next year?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that's what our team (OpenAPI.net, OpenAPI.net.Odata, this. Microsoft.Plugins.Manifest, kiota, Microsoft.Graph....) has been doing for the past couple of years.
This requires us to be reactive, but gives an escape hatch in case a breaking change would happen with the new version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doesn't sound ideal if it blocks people from being able to test their apps with .NET 10 at all if you don't relax the restriction until November 2025.
I don't happen to use anything that depends on this assembly, but I test my apps with every preview of .NET before they reach GA. This restriction would be a blocker to any such testing, and it's also not good for users who want to adopt .NET vNext on day 0 and find it to be impossible due to the upper constraint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Microsoft.OpenApi have such a restriction? I've had zero issues with it with testing the new Microsoft.AspNetCore.OpenApi package in the .NET 9 previews and the final release. If it did, I feel I'd have opened an issue against it many many months ago about it asking for it to be removed already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Microsoft.OpenAPI is just a set of abstractions, so it does not have any dependencies.
Microsoft.OpenApi.Readers does not depend on STJ (or newtonsoft), but rather on sharpYAML
This is one of the improvements of the upcoming v2 which now makes me realize using a range was forgotten in the process.
Created an issue to address this before the GA microsoft/OpenAPI.NET#1930
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My issue with this is that it allows you to review any breaking changes, but doesn't allow anyone else to.
This removes a lot of the value to the .NET teams (and yourselves) of customers using your libraries in their own applications and providing feedback over the course of the .NET 10 development lifecycle. If anyone finds an issue you don't find yourself, you won't find out about it until .NET 10 GA, at which point it's "too late".
My take is it's much better to not have the upper bound, and then let people take it for a spin themselves. If there are issues, you'll get bug reports and they can be resolved in advance of .NET 10 GA. If there aren't any issues, everyone's happy and there's nothing to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, there's a very good chance I'll pop up in February 2025 with an issue saying I can't test any of my OpenAPI-consuming applications with .NET 10 previews and asking for a fix 😃