Skip to content

Conversation

@peombwa
Copy link
Contributor

@peombwa peombwa commented Sep 26, 2023

This PR fixes #17 and fixes #21 by:

  • Adds validation for apiDeploymentBaseUrl on set. The validation ensures that the provided value is an absolute URL with a trailing slash per the spec.
  • Renames Request class to RequestInfo to align with the spec.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@peombwa peombwa marked this pull request as ready for review September 27, 2023 20:24
@peombwa peombwa merged commit 2c5a119 into main Sep 28, 2023
@peombwa peombwa deleted the po/alignWithSpec branch September 28, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename Request class to RequestInfo. Validate apiDependency.apiDeploymentBaseUrl for trailing slash when provided.

3 participants