Skip to content

Conversation

@peombwa
Copy link
Contributor

@peombwa peombwa commented Dec 5, 2023

This PR fixes #53 by:

  • Changes lib target framework to netstandard2.0 to be compatible with OpenAPI.NET and Semantic Kernel.
  • Sets C# language version to 10 to be compatible with .NET 6, which is supported by Semantic Kernel.
  • Addresses changes attributed to the above changes.

@peombwa peombwa self-assigned this Dec 5, 2023
@peombwa peombwa marked this pull request as ready for review December 6, 2023 19:25
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get why we're doing that, I'm just not happy to see the code go back in time 💩💩💩💩

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.7% 94.7% Coverage
0.0% 0.0% Duplication

@peombwa peombwa enabled auto-merge December 6, 2023 22:25
@peombwa peombwa requested a review from baywet December 6, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support netstandard2.0 as a target framework

4 participants