Preserve exception stack traces

[0xced]

See https://stackoverflow.com/questions/730250/is-there-a-difference-between-throw-and-throw-ex/730255#730255

[MattB-msft]

@0xced Is there some reason you feel that is necessary? We did that intentionally to limit the stack trace that was exported.
is there something your trying to do with the dump?

[0xced]

We did that intentionally to limit the stack trace that was exported.

This seems weird to me. Losing some part of the original stack trace will just make it harder to diagnose issues. Many analyzers suggest to rethrow exceptions with throw; instead of throw ex;.

• .NET source code analysis: CA2200
• Meziantou.Analyzer: MA0027
• ExceptionAnalyzer: EA004

The best practices for exceptions also recommends the same:

private static void TransferFunds(Account from, Account to, decimal amount)
{
    string withdrawalTrxID = from.Withdrawal(amount);
    try
    {
        to.Deposit(amount);
    }
    catch
    {
        from.RollbackTransaction(withdrawalTrxID);
        throw;
    }
}

This example illustrates the use of throw to re-throw the original exception, which can make it easier for callers to see the real cause of the problem without having to examine the InnerException property.

[0xced]

Would you mind reconsidering this pull request?

[MattB-msft]

@0xced , We have decided to go back though and relax a few places where we limit the stack, the areas you highlighted here are some of those areas we are refactoring to pass the source though.

We will close this PR when we ship this update.