Skip to content

Resync from mainline. #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2025
Merged

Resync from mainline. #505

merged 1 commit into from
Apr 5, 2025

Conversation

MattB-msft
Copy link
Member

This pull request includes several updates to the DataverseClient project, focusing on upgrading target frameworks, improving logging, and enhancing error handling. Below is a summary of the most significant changes:

Framework Upgrades:

  • Updated target frameworks from net6.0 to net8.0 in multiple project files, including Build.Common.StandardAndLegacy.props, Build.Common.core.props, and various test and PowerShell project files. [1] [2] [3] [4] [5] [6] [7] [8]

Logging Improvements:

  • Modified constructors in AzAuth and AzPipelineFederatedIdentityAuth to use NullLogger.Instance when a logger is not provided, ensuring that logging is always initialized. [1] [2]

Error Handling Enhancements:

  • Added an ErrorMessage property to the AuthenticationDetails class and updated the ProbeForExpectedAuthentication method to set detailed error messages when probing fails. [1] [2] [3] [4] [5]

Dependency Updates:

  • Updated System.ServiceModel package version for post-net6.0 from 6.2.0 to 8.1.2 in Packages.props.

Minor Fixes:

  • Corrected a typo in a method comment in AuthorityResolver.cs and added a missing parameter in AuthProcessor.cs. [1] [2]

These changes collectively improve the robustness, maintainability, and compatibility of the DataverseClient project.

@MattB-msft MattB-msft marked this pull request as ready for review April 5, 2025 17:20
@MattB-msft MattB-msft merged commit 4ed7e5b into master Apr 5, 2025
1 check passed
@MattB-msft
Copy link
Member Author

Fix for #481
Fix for #463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AzAuth errors out without Logger Memory leak on RetrieveMultipleAsync
1 participant