-
Notifications
You must be signed in to change notification settings - Fork 191
GitHubRepositoryForks: Update Repo Name in Tests #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHubRepositoryForks: Update Repo Name in Tests #251
Conversation
I merged this in immediately yesterday without bothering with verifying CI because the change seemed so banal. In practice though, it looks like this has somehow almost doubled the runtime of the CI. Up until this point, builds had been running in the 30-35 min range. I re-ran a CI build this morning at 41de3ad (that's the commit in The very next commit is 19c8417 (this change). That build is taking about 60 min (the build times out if any job exceeds that time). Every CI build that has happened after that commit went in is now running at around 60 min. I'm inclined to roll this change back until the change is better understood. When I run A possible middle ground would be to to define different values for |
You are right, it is taking 20 minutes in the CI to run the fork tests. Here is a snippet of the raw logs from one of the CIs with times:
It is a tiny repo, with only one file, but it does already have 1,400 forks. I think running |
Pull microsoft#251 changed the repo targeted by the forks tests from `microsoft/PowerShellForGitHub` to `octocat/Hello-World` in order to prevent the accidental deletion of real forks when running the UT's locally against your own account. In practice, this almost doubled the execution time of the UT's, because the execution time of the Forks API's took so much longer against a repo with 1400+ forks. Changing the test over to use a repo that currently only has 39 forks (several orders of magnitude fewer).
Pull #251 changed the repo targeted by the forks tests from `microsoft/PowerShellForGitHub` to `octocat/Hello-World` in order to prevent the accidental deletion of real forks when running the UT's locally against your own account. In practice, this almost doubled the execution time of the UT's, because the execution time of the Forks API's took so much longer against a repo with 1400+ forks. Changing the test over to use a repo that currently only has 39 forks (several orders of magnitude fewer).
Description
This PR updates the upstream Owner and Repo name used in the
GitHubRepositoryForks
tests to cause less destruction.Issues Fixed
None
References
N/A
Checklist
Comment-based help added/updated, including examples.Static analysis is reporting back clean.New/changed code adheres to our coding guidelines.New/changed code continues to support the pipeline.Changes to the manifest file follow the manifest guidance.Relevant usage examples have been added/updated in USAGE.md.If desired, ensure your name is added to our Contributors list