Skip to content

[Hosts] Adds no whitespace option(#36386) #38248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Hosts] Adds no whitespace option(#36386) #38248

wants to merge 2 commits into from

Conversation

turkerayan
Copy link

@turkerayan turkerayan commented Mar 31, 2025 •
edited by jamrobot
Loading

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

image

htcfreek
htcfreek suggested changes Mar 31, 2025
View reviewed changes
Copy link
Collaborator

@htcfreek htcfreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Wrong place and icon for settings.
  2. Duplicate PR.

@turkerayan
Copy link
Author

  1. Wrong place and icon for settings.
  2. Duplicate PR.

#36386 (comment)

This comment indicated that place

@turkerayan
Copy link
Author

@microsoft-github-policy-service agree

@crutkas crutkas added the Needs-Review This Pull Request awaits the review of a maintainer. label Apr 7, 2025
@jamrobot jamrobot requested a review from zhaopy536 April 8, 2025 00:16
@jamrobot jamrobot added the Product-Hosts File Editor Refers to the Hosts file editor label Apr 8, 2025
@jamrobot jamrobot changed the title Adds no whitespace option(#36386) [Hosts] Adds no whitespace option(#36386) Apr 8, 2025
@chenmy77 chenmy77 self-requested a review April 8, 2025 06:21
@crutkas
Copy link
Member

crutkas commented Jul 10, 2025

this and #37852 are trying to solve the same problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htcfreek htcfreek htcfreek requested changes

@zhaopy536 zhaopy536 Awaiting requested review from zhaopy536

@chenmy77 chenmy77 Awaiting requested review from chenmy77

At least 1 approving review is required to merge this pull request.

Assignees

@jamrobot jamrobot

@chenmy77 chenmy77

Labels
Needs-Review This Pull Request awaits the review of a maintainer. Product-Hosts File Editor Refers to the Hosts file editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@turkerayan @crutkas @htcfreek @jamrobot @chenmy77