Skip to content

[AlwaysOnTop]Display slider values in 'AlwaysOnTop' settings #38606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vamsiikrishnaak
Copy link

@vamsiikrishnaak vamsiikrishnaak commented Apr 6, 2025

Summary of the Pull Request

  • Along with the slider in settings, a text block is added whose value is binded to the slider value.
  • The change is done for both Opacity and Thickness settings.
  • Tested manually.

image

PR Checklist

Detailed Description of the Pull Request / Additional comments

  • I have checked Windows Terminal's settings and tried to mimic the same.
  • Stackpanel is used to combine the slider control along with the new textblock.
  • I have set the margin-left, width and vertical alignment properties of textblock to ensure that other controls are unaffected.

Validation Steps Performed

  • Tested manually with different window sizes.

@vamsiikrishnaak vamsiikrishnaak changed the title Display slider values in 'AlwaysOnTop' settings page Display slider values in 'AlwaysOnTop' settings Apr 7, 2025
@yeelam-gordon yeelam-gordon added the Product-Always On Top Refers to the idea of a Always on Top Powertoy label Apr 8, 2025
@yeelam-gordon yeelam-gordon requested a review from Copilot April 9, 2025 04:42
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/settings-ui/Settings.UI/SettingsXAML/Views/AlwaysOnTopPage.xaml: Language not supported

@jamrobot jamrobot changed the title Display slider values in 'AlwaysOnTop' settings [AlwaysOnTop]Display slider values in 'AlwaysOnTop' settings Apr 10, 2025
@jamrobot jamrobot added the Needs-Review This Pull Request awaits the review of a maintainer. label Apr 10, 2025
@jamrobot jamrobot requested a review from wang563681252 April 10, 2025 05:45
@jamrobot jamrobot self-assigned this Apr 10, 2025
@crutkas
Copy link
Member

crutkas commented Jun 7, 2025

@niels9001 can you look at this.

@crutkas
Copy link
Member

crutkas commented Jun 7, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@niels9001 niels9001 self-requested a review June 7, 2025 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Review This Pull Request awaits the review of a maintainer. Product-Always On Top Refers to the idea of a Always on Top Powertoy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants