Fix Cmdpal launch without admin mode - both runner and setting. #39494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the Cmdpal launch issue by updating both the runner and settings functionality to launch Cmdpal without admin mode.
- Updated LaunchApp method to accept command line arguments.
- Adjusted CmdPal settings and module interface usage to launch via explorer.exe with proper argument separation.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/settings-ui/Settings.UI/SettingsXAML/Views/CmdPalPage.xaml.cs | Modified the LaunchApp signature and updated the settings deeplink click handler to pass arguments separately. |
| src/modules/cmdpal/CmdPalModuleInterface/dllmain.cpp | Updated the launch command for background execution and modified the RetryLaunch method to include command arguments. |
lei9444
approved these changes
May 16, 2025
shuaiyuanxx
approved these changes
May 16, 2025
yeelam-gordon
added a commit
that referenced
this pull request
May 19, 2025
* Change to path and args * Fix both Setting launch and runner launch
yeelam-gordon
added
the
Product-Command Palette
sadirano
pushed a commit
to sadirano/PowerToys
that referenced
this pull request
Jun 10, 2025
…osoft#39494) * Change to path and args * Fix both Setting launch and runner launch
yeelam-gordon
added a commit
that referenced
this pull request
Jun 20, 2025
* Change to path and args * Fix both Setting launch and runner launch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Previous PR haven't fully test yet.
This PR will address both runner and setting launching cmdpal.
PR Checklist