fix: merge datascience v3 and v2#974
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR merges the handling of proposal versions by removing v3-specific code paths and streamlining configuration and prompt instructions.
- Removed DSProposalV3ExpGen references and related conditionals from data science proposal generation.
- Updated YAML prompts for experiment submissions and feedback adjustments.
- Added support for function calling in LLM backends, including new configuration settings and abstract method definitions.
Reviewed Changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rdagent/scenarios/data_science/loop.py | Removed v3-specific imports and conditional branches to unify version handling. |
| rdagent/scenarios/data_science/dev/prompts.yaml | Updated experiment prompt instructions to clarify submission handling. |
| rdagent/scenarios/data_science/dev/feedback.py | Removed untested v3-specific feedback generation logic. |
| rdagent/oai/llm_conf.py | Introduced a new configuration option for enabling function calling. |
| rdagent/oai/backend/litellm.py | Adjusted response_format handling and added support_function_calling method. |
| rdagent/oai/backend/deprec.py | Added support_function_calling with a FIXME comment indicating pending improvement. |
| rdagent/oai/backend/base.py | Added an abstract support_function_calling method to enforce subclass implementations. |
| rdagent/components/coder/data_science/pipeline/prompts.yaml | Removed v3-specific pipeline prompt sections. |
| rdagent/components/coder/data_science/pipeline/init.py | Eliminated a temporary patch for proposal version v3 in the pipeline coder. |
Comments suppressed due to low confidence (2)
rdagent/scenarios/data_science/loop.py:96
- Ensure that using import_class to handle 'v3' (which is now absent from the valid list) produces the expected behavior and does not inadvertently bypass necessary initialization steps.
if DS_RD_SETTING.proposal_version not in ["v1", "v2"]:
rdagent/oai/backend/litellm.py:93
- Review the removal of 'response_format' from kwargs, as this may affect downstream consumers expecting this field; ensure that clients are updated accordingly.
elif not supports_response_schema(model=LITELLM_SETTINGS.chat_model) and "response_format" in kwargs:
This was referenced Jun 30, 2025
licong01-cloud
pushed a commit
to licong01-cloud/RD-Agent
that referenced
this pull request
Dec 13, 2025
* add coder version * merge cooder and feedback prompts * align v2 and v3 proposal prompts * fix a small bug * fix a bug * fix another bug * support both function calling and json mode in v2 proposal * fix minor bug * reformat * remove proposal v3 * fix a small bug in json mode * fix CI * remove tmp file * remove v3 check --------- Co-authored-by: Xu Yang <xuyang1@microsoft.com>
yongbin4
pushed a commit
to yongbin4/RD-Agent
that referenced
this pull request
Mar 8, 2026
* add coder version * merge cooder and feedback prompts * align v2 and v3 proposal prompts * fix a small bug * fix a bug * fix another bug * support both function calling and json mode in v2 proposal * fix minor bug * reformat * remove proposal v3 * fix a small bug in json mode * fix CI * remove tmp file * remove v3 check --------- Co-authored-by: Xu Yang <xuyang1@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Screenshots of Test Results (if appropriate):
Types of changes
📚 Documentation preview 📚: https://RDAgent--974.org.readthedocs.build/en/974/