Fixed broken build #113
Open
Fixed broken build #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem was because TpmAtt.h was redefining a number of structs from the SDK's wbcl.h, so they have been removed. TpmAtt.h also declared 3 functions that are already declared in wbcl.h, but we cannot remove them because TpmAtt dll is exporting these functions and thus they must be declared with the __declspec(dllexport) storage class (which wbcl.h doesn't). TpmAtt is defining and exporting these functions because the repo does not have tpmapi.lib to link against. So no choice but to rename them. An alternative solution may be to use a .def file to export the functions (thereby avoiding the need to redeclare the functions with __declspec(dllexport)). This will allow us to keep the original function name.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #94
Problem was because TpmAtt.h was redefining a number of structs from the SDK's wbcl.h, so they have been removed.
TpmAtt.h also declared 3 functions that are already declared in wbcl.h, but we cannot remove them because TpmAtt dll is exporting these functions and thus they must be declared with the __declspec(dllexport) storage class (which wbcl.h doesn't). TpmAtt is defining and exporting these functions because the repo does not have tpmapi.lib to link against. So no choice but to rename them. An alternative solution may be to use a .def file to export the functions (thereby avoiding the need to redeclare the functions with __declspec(dllexport)). This will allow us to keep the original function name.