Updates to PCPTool #181
Updates to PCPTool #181
Conversation
…eral keys in one operation
@microsoft-github-policy-service agree |
PCPTool.v11/exe/SDKSample.cpp
Outdated
| } | ||
| hr = S_OK; | ||
| continue; | ||
| goto Cleanup; |
There was a problem hiding this comment.
the goto statement can be deleted.
There was a problem hiding this comment.
Thank you for spotting it. I have removed it!
PCPTool.v11/exe/SDKSample.cpp
Outdated
| { | ||
| wprintf(L" Failed (0x%08lx)\n", hr); | ||
| } | ||
| else { |
There was a problem hiding this comment.
Could you uniform styles? Here { is on same line as else. On others its on next line.
PCPTool.v11/exe/SDKSample.cpp
Outdated
| } | ||
| } | ||
|
|
||
| if (matchingKeys == 0) { |
There was a problem hiding this comment.
Similarly, { is on same line as if here but on new line in other places.
PCPTool.v11/inc/TpmAtt.h
Outdated
|
|
||
| // SIPA event structures | ||
|
|
||
| //// |
There was a problem hiding this comment.
Please delete old declarations or code (to see what the previous code looked like, one can use git history).
There was a problem hiding this comment.
@ksmith3036 old PR but if you refresh and confirm I am happy to review and merge
dwizzzle
left a comment
dwizzzle
left a comment
There was a problem hiding this comment.
changes look good to me and covered Ron's feedback
3 participants
Updated to new build tools and new Windows SDK. Fixed conflicting method declarations.
Fixed handling of user versus machine keys.
Added DeleteKeys method, accepting a regex as argument, to delete several keys in one operation.