Skip to content

Fix incorrect extract of comments #2077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2025

Conversation

saschanaz
Copy link
Contributor

Apparently the regex was too greedy and ate more characters than it should.

Lesson learned again: Don't use complex regex until it's super duper needed. If you think it's super duper needed, think again.

Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

Copy link
Contributor

@Bashamega Bashamega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@saschanaz
Copy link
Contributor Author

LGTM

@github-actions github-actions bot merged commit 174b76c into microsoft:main Jul 20, 2025
7 checks passed
Copy link
Contributor

Merging because @saschanaz is a code-owner of all the changes - thanks!

@github-actions github-actions bot deleted the fix-comment-paragraph branch July 20, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants