Add missing optional constructor param for Text

[alexeagle]

/cc @samccone

[msftclas]

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

[saschanaz]

The file must not be modified:

Instead you can modify [added/overriding/removed]Types.json.

[alexeagle]

Thanks - in that case, what is the mechanism to change the lib.dom.d.ts that is distributed with TypeScript? Does it require a change to Edge where this IDL originates?

…

On Tue, Apr 4, 2017 at 9:48 PM Kagami Sascha Rosylight < ***@***.***> wrote: The file must not be modified <https://github.com/Microsoft/TSJS-lib-generator/blob/master/inputfiles/README.md> : [image: image] <https://cloud.githubusercontent.com/assets/3396686/24690195/507166ec-1a06-11e7-9117-fe5f512d2f9d.png> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#229 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAC5Ixj_rHgmHlYeXuop_WoJyq32VXw-ks5rsxy_gaJpZM4MzjRs> .

[saschanaz]

You'll want to look at addedTypes.json to add a constructor to an interface.

[saschanaz]

Make sure you get pass on the build script to solve the CI failure! The generated directory will have new files and you have to copy-paste them to baselines directory.

[alexeagle]

The CI only says that the generated file doesn't match the baseline, without printing the diff. I guess I'll have to install Mono so I can generate the files locally.

[alexeagle]

Thanks for the help @saschanaz !

[samccone]

Thanks @alexeagle

[mhegazy]

Link to documentation: https://dom.spec.whatwg.org/#text

For future purposes, please file an issue on the TS repo along with the change.

[mhegazy]

thanks!

[mhegazy]

and thanks @saschanaz!

[samccone]

thank you for landing @mhegazy