Skip to content

Update IDBDatabase interface #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2016
Merged

Conversation

falsandtru
Copy link
Contributor

@msftclas
Copy link

msftclas commented Jan 1, 2016

Hi @falsandtru, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@falsandtru
Copy link
Contributor Author

ouch

@msftclas
Copy link

msftclas commented Jan 1, 2016

@falsandtru, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@ghost
Copy link

ghost commented Jan 2, 2016

Is there any issue tracking this in TypeScript repo? A link to it would be nice.
This PR needs to be squashed to a single commit for multiple reasons. So:

cd TSJS-lib-generator
git rebase -i HEAD~4
# editor will open
# replace `pick` with `f`, for all lines except the first one, save and close the editor
git push -f

@falsandtru
Copy link
Contributor Author

I didn't report this issue in TypeScript repo.

@mhegazy
Copy link
Contributor

mhegazy commented Jan 4, 2016

@falsandtru thanks for the PR, two comments:

  1. please file an issue on the TS repo, this will allow for documenting the change.
  2. do not change the webidl file directly, this file is external. put your changes in https://github.com/Microsoft/TSJS-lib-generator/blob/master/inputfiles/overridingTypes.json instead.

@falsandtru
Copy link
Contributor Author

All right, I'll fix it. And now, is there a way to fix webidl files?

@mhegazy
Copy link
Contributor

mhegazy commented Jan 4, 2016

The webidl files are external. we grab them periodically from the IE/Edge team. files inputfiles/addedTypes.json, inputfiles/overridingTypes.json, and inputfiles/removedTypes.json allow to augment the webidl definitions to get the desired shape. this way when a new version of the webidl is picked up the augmentations are not lost.

See Readme.md for more information.

@falsandtru
Copy link
Contributor Author

I understood that. Thanks.

@falsandtru
Copy link
Contributor Author

@mhegazy I filed a new issue: microsoft/TypeScript#6408, and I fixed your specified points. Please review, @mhegazy @zhengbli .

@falsandtru
Copy link
Contributor Author

I have some unpublished fixes. I want to send that fixes after accepting this commit.

@mhegazy
Copy link
Contributor

mhegazy commented Jan 11, 2016

👍

zhengbli added a commit that referenced this pull request Jan 11, 2016
Update `IDBDatabase` interface
@zhengbli zhengbli merged commit 9951366 into microsoft:master Jan 11, 2016
@zhengbli
Copy link
Contributor

@falsandtru Thank you for contributing!

@falsandtru falsandtru deleted the patch-1 branch January 15, 2016 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants