-
Notifications
You must be signed in to change notification settings - Fork 440
Update IDBDatabase
interface
#36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @falsandtru, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
ouch |
@falsandtru, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
Is there any issue tracking this in TypeScript repo? A link to it would be nice. cd TSJS-lib-generator
git rebase -i HEAD~4
# editor will open
# replace `pick` with `f`, for all lines except the first one, save and close the editor
git push -f |
I didn't report this issue in TypeScript repo. |
@falsandtru thanks for the PR, two comments:
|
All right, I'll fix it. And now, is there a way to fix webidl files? |
The webidl files are external. we grab them periodically from the IE/Edge team. files See Readme.md for more information. |
I understood that. Thanks. |
@mhegazy I filed a new issue: microsoft/TypeScript#6408, and I fixed your specified points. Please review, @mhegazy @zhengbli . |
I have some unpublished fixes. I want to send that fixes after accepting this commit. |
👍 |
Update `IDBDatabase` interface
@falsandtru Thank you for contributing! |
http://www.w3.org/TR/IndexedDB/#database-interface