Skip to content

Change setValueCurveAtTime values to Float32Array #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Change setValueCurveAtTime values to Float32Array #408

wants to merge 1 commit into from

Conversation

iccir
Copy link

@iccir iccir commented Apr 5, 2018

@msftclas
Copy link

msftclas commented Apr 5, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

@mhegazy
Copy link
Contributor

mhegazy commented Apr 5, 2018

I think the problem here is in our serialization code. the type is correctly defined in the input file.. it is just we did not translate it correctly..

@mhegazy mhegazy mentioned this pull request Apr 5, 2018
Merged
@mhegazy
Copy link
Contributor

mhegazy commented Apr 5, 2018

Pushed an alternative fix in #409

@mhegazy
Copy link
Contributor

mhegazy commented Apr 5, 2018

closing in favor of #409

@mhegazy mhegazy closed this Apr 5, 2018
@saschanaz saschanaz mentioned this pull request Apr 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iccir @msftclas @mhegazy