Skip to content

Use number[]|Float32Array union #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2018
Merged

Use number[]|Float32Array union #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1082,8 +1082,8 @@ interface PeriodicWaveConstraints {
}

interface PeriodicWaveOptions extends PeriodicWaveConstraints {
imag?: Float32Array;
real?: Float32Array;
imag?: number[] | Float32Array;
real?: number[] | Float32Array;
}

interface PointerEventInit extends MouseEventInit {
Expand Down Expand Up @@ -1693,8 +1693,8 @@ interface VRDisplayEventInit extends EventInit {
}

interface VRLayer {
leftBounds?: Float32Array | null;
rightBounds?: Float32Array | null;
leftBounds?: number[] | Float32Array | null;
rightBounds?: number[] | Float32Array | null;
source?: HTMLCanvasElement | null;
}

Expand All @@ -1705,7 +1705,7 @@ interface VRStageParameters {
}

interface WaveShaperOptions extends AudioNodeOptions {
curve?: Float32Array;
curve?: number[] | Float32Array;
oversample?: OverSampleType;
}

Expand Down Expand Up @@ -2108,7 +2108,7 @@ interface AudioParam {
linearRampToValueAtTime(value: number, endTime: number): AudioParam;
setTargetAtTime(target: number, startTime: number, timeConstant: number): AudioParam;
setValueAtTime(value: number, startTime: number): AudioParam;
setValueCurveAtTime(values: Float32Array, startTime: number, duration: number): AudioParam;
setValueCurveAtTime(values: number[] | Float32Array, startTime: number, duration: number): AudioParam;
}

declare var AudioParam: {
Expand Down
2 changes: 1 addition & 1 deletion src/emitter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ export function emitWebIDl(webidl: Browser.WebIdl, flavor: Flavor) {

function makeArrayType(elementType: string, obj: Browser.Typed): string {
if (obj.subtype && !Array.isArray(obj.subtype) && obj.subtype.type === "float") {
return "Float32Array";
return "number[] | Float32Array";
}

return elementType.includes("|") ? `(${elementType})[]` : `${elementType}[]`;
Expand Down