Skip to content

Introduce composedPath for Events #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 12, 2018
Merged

Introduce composedPath for Events #523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
168d493
Introduce composedPath for Events
43081j Jul 3, 2018
2d6bcef
add DOM IDL input files
43081j Jul 3, 2018
d5f035f
add HTML IDL files
43081j Jul 5, 2018
cc1c353
move events to global handlers
43081j Jul 5, 2018
874d815
remove removed handlers
43081j Jul 5, 2018
0f8015e
update baselines
43081j Jul 5, 2018
49e2bf0
parenthesise variadic params with multiple types
43081j Jul 5, 2018
bc7868f
reintroduce getelementsByTagName overrides
43081j Jul 6, 2018
ce12916
account for events which inherit UIEvent
43081j Jul 6, 2018
ab5655c
reintroduce clipboard events
43081j Jul 6, 2018
1b5d500
include all *Event inheritance in event type lists
43081j Jul 6, 2018
835b579
reintroduce specific event types
43081j Jul 6, 2018
987cf19
revert nodelists to using numeric keys
43081j Jul 6, 2018
260bdbd
add abort event
43081j Jul 10, 2018
a1117a3
regenerate baseline
43081j Jul 11, 2018
0520e3e
use indents for comments
43081j Jul 11, 2018
cf68da3
update baseline
43081j Jul 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,455 changes: 1,055 additions & 400 deletions baselines/dom.generated.d.ts
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions baselines/dom.iterable.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ interface DOMStringList {

interface DOMTokenList {
[Symbol.iterator](): IterableIterator<string>;
entries(): IterableIterator<[number, string]>;
keys(): IterableIterator<number>;
values(): IterableIterator<string>;
}

interface DataTransferItemList {
Expand Down
110 changes: 104 additions & 6 deletions baselines/webworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ interface CloseEventInit extends EventInit {
wasClean?: boolean;
}

interface CustomEventInit<T = any> extends EventInit {
detail?: T;
}

interface DOMMatrix2DInit {
a?: number;
b?: number;
Expand Down Expand Up @@ -275,11 +279,32 @@ interface EventListener {
(evt: Event): void;
}

interface AbortController {
/**
* Returns the AbortSignal object associated with this object.
*/
readonly signal: AbortSignal;
/**
* Invoking this method will set this object's AbortSignal's aborted flag and
* signal to any observers that the associated activity is to be aborted.
*/
abort(): void;
}

declare var AbortController: {
prototype: AbortController;
new(): AbortController;
};

interface AbortSignalEventMap {
"abort": ProgressEvent;
}

interface AbortSignal extends EventTarget {
/**
* Returns true if this AbortSignal's AbortController has signaled to abort, and false
* otherwise.
*/
readonly aborted: boolean;
onabort: ((this: AbortSignal, ev: ProgressEvent) => any) | null;
addEventListener<K extends keyof AbortSignalEventMap>(type: K, listener: (this: AbortSignal, ev: AbortSignalEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
Expand Down Expand Up @@ -530,6 +555,20 @@ declare var CryptoKey: {
new(): CryptoKey;
};

interface CustomEvent<T = any> extends Event {
/**
* Returns any custom data event was created with.
* Typically used for synthetic events.
*/
readonly detail: T;
initCustomEvent(typeArg: string, canBubbleArg: boolean, cancelableArg: boolean, detailArg: T): void;
}

declare var CustomEvent: {
prototype: CustomEvent;
new<T>(typeArg: string, eventInitDict?: CustomEventInit<T>): CustomEvent<T>;
};

interface DOMException {
readonly code: number;
readonly message: string;
Expand Down Expand Up @@ -835,22 +874,56 @@ declare var ErrorEvent: {
};

interface Event {
/**
* Returns true or false depending on how event was initialized. True if event goes through its target's ancestors in reverse tree order, and false otherwise.
*/
readonly bubbles: boolean;
cancelBubble: boolean;
readonly cancelable: boolean;
/**
* Returns true or false depending on how event was initialized. True if event invokes listeners past a ShadowRoot node that is the root of its target, and false otherwise.
*/
readonly composed: boolean;
/**
* Returns the object whose event listener's callback is currently being
* invoked.
*/
readonly currentTarget: EventTarget | null;
readonly defaultPrevented: boolean;
readonly eventPhase: number;
/**
* Returns true if event was dispatched by the user agent, and
* false otherwise.
*/
readonly isTrusted: boolean;
returnValue: boolean;
/**
* Returns the object to which event is dispatched (its target).
*/
readonly target: EventTarget | null;
/**
* Returns the event's timestamp as the number of milliseconds measured relative to
* the time origin.
*/
readonly timeStamp: number;
/**
* Returns the type of event, e.g.
* "click", "hashchange", or
* "submit".
*/
readonly type: string;
deepPath(): EventTarget[];
composedPath(): EventTarget[];
initEvent(type: string, bubbles?: boolean, cancelable?: boolean): void;
preventDefault(): void;
/**
* Invoking this method prevents event from reaching
* any registered event listeners after the current one finishes running and, when dispatched in a tree, also prevents event from reaching any
* other objects.
*/
stopImmediatePropagation(): void;
/**
* When dispatched in a tree, invoking this method prevents event from reaching any objects other than the current object.
*/
stopPropagation(): void;
readonly AT_TARGET: number;
readonly BUBBLING_PHASE: number;
Expand All @@ -860,7 +933,7 @@ interface Event {

declare var Event: {
prototype: Event;
new(typeArg: string, eventInitDict?: EventInit): Event;
new(type: string, eventInitDict?: EventInit): Event;
readonly AT_TARGET: number;
readonly BUBBLING_PHASE: number;
readonly CAPTURING_PHASE: number;
Expand Down Expand Up @@ -894,9 +967,26 @@ interface EventSourceInit {
}

interface EventTarget {
/**
* Appends an event listener for events whose type attribute value is type. The callback argument sets the callback that will be invoked when the event is dispatched.
* The options argument sets listener-specific options. For compatibility this can be a
* boolean, in which case the method behaves exactly as if the value was specified as options's capture.
* When set to true, options's capture prevents callback from being invoked when the event's eventPhase attribute value is BUBBLING_PHASE. When false (or not present), callback will not be invoked when event's eventPhase attribute value is CAPTURING_PHASE. Either way, callback will be invoked if event's eventPhase attribute value is AT_TARGET.
* When set to true, options's passive indicates that the callback will not cancel the event by invoking preventDefault(). This is used to enable performance optimizations described in §2.8 Observing event listeners.
* When set to true, options's once indicates that the callback will only be invoked once after which the event listener will
* be removed.
* The event listener is appended to target's event listener list and is not appended if it has the same type, callback, and capture.
*/
addEventListener(type: string, listener: EventListenerOrEventListenerObject | null, options?: boolean | AddEventListenerOptions): void;
dispatchEvent(evt: Event): boolean;
removeEventListener(type: string, listener?: EventListenerOrEventListenerObject | null, options?: EventListenerOptions | boolean): void;
/**
* Dispatches a synthetic event event to target and returns true
* if either event's cancelable attribute value is false or its preventDefault() method was not invoked, and false otherwise.
*/
dispatchEvent(event: Event): boolean;
/**
* Removes the event listener in target's event listener list with the same type, callback, and options.
*/
removeEventListener(type: string, callback: EventListenerOrEventListenerObject | null, options?: EventListenerOptions | boolean): void;
}

declare var EventTarget: {
Expand Down Expand Up @@ -2658,15 +2748,23 @@ interface PerformanceObserverCallback {
declare var onmessage: ((this: DedicatedWorkerGlobalScope, ev: MessageEvent) => any) | null;
declare function close(): void;
declare function postMessage(message: any, transfer?: any[]): void;
declare function dispatchEvent(evt: Event): boolean;
/**
* Dispatches a synthetic event event to target and returns true
* if either event's cancelable attribute value is false or its preventDefault() method was not invoked, and false otherwise.
*/
declare function dispatchEvent(event: Event): boolean;
declare var caches: CacheStorage;
declare var isSecureContext: boolean;
declare var location: WorkerLocation;
declare var onerror: ((this: DedicatedWorkerGlobalScope, ev: ErrorEvent) => any) | null;
declare var performance: Performance;
declare var self: WorkerGlobalScope;
declare function msWriteProfilerMark(profilerMarkName: string): void;
declare function dispatchEvent(evt: Event): boolean;
/**
* Dispatches a synthetic event event to target and returns true
* if either event's cancelable attribute value is false or its preventDefault() method was not invoked, and false otherwise.
*/
declare function dispatchEvent(event: Event): boolean;
declare var indexedDB: IDBFactory;
declare var msIndexedDB: IDBFactory;
declare var navigator: WorkerNavigator;
Expand Down
142 changes: 120 additions & 22 deletions inputfiles/addedTypes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,122 @@
{
"mixins": {
"mixin": {
"DocumentAndElementEventHandlers": {
"events": {
"event": [
{
"name": "copy",
"type": "ClipboardEvent"
},
{
"name": "cut",
"type": "ClipboardEvent"
},
{
"name": "paste",
"type": "ClipboardEvent"
}
]
}
},
"GlobalEventHandlers": {
"events": {
"event": [
{
"name": "cancel",
"type": "Event"
},
{
"name": "drag",
"type": "DragEvent"
},
{
"name": "dragend",
"type": "DragEvent"
},
{
"name": "dragenter",
"type": "DragEvent"
},
{
"name": "dragleave",
"type": "DragEvent"
},
{
"name": "dragover",
"type": "DragEvent"
},
{
"name": "dragstart",
"type": "DragEvent"
},
{
"name": "drop",
"type": "DragEvent"
},
{
"name": "keydown",
"type": "KeyboardEvent"
},
{
"name": "keypress",
"type": "KeyboardEvent"
},
{
"name": "keyup",
"type": "KeyboardEvent"
},
{
"name": "mousedown",
"type": "MouseEvent"
},
{
"name": "mouseenter",
"type": "MouseEvent"
},
{
"name": "mouseleave",
"type": "MouseEvent"
},
{
"name": "mousemove",
"type": "MouseEvent"
},
{
"name": "mouseout",
"type": "MouseEvent"
},
{
"name": "mouseover",
"type": "MouseEvent"
},
{
"name": "mouseup",
"type": "MouseEvent"
},
{
"name": "scroll",
"type": "UIEvent"
},
{
"name": "select",
"type": "UIEvent"
},
{
"name": "wheel",
"type": "WheelEvent"
},
{
"name": "securitypolicyviolation",
"type": "SecurityPolicyViolationEvent"
},
{
"name": "dblclick",
"type": "MouseEvent"
},
{
"name": "contextmenu",
"type": "MouseEvent"
}
]
}
Expand Down Expand Up @@ -73,6 +183,16 @@
},
"interfaces": {
"interface": {
"AbortSignal": {
"events": {
"event": [
{
"name": "abort",
"type": "ProgressEvent"
}
]
}
},
"ApplicationCache": {
"events": {
"event": [
Expand Down Expand Up @@ -1113,28 +1233,6 @@
}
}
},
"Event": {
"name": "Event",
"properties": {
"property": {
"composed": {
"name": "composed",
"read-only": 1,
"override-type": "boolean"
}
}
},
"methods": {
"method": {
"deepPath": {
"name": "deepPath",
"override-signatures": [
"deepPath(): EventTarget[]"
]
}
}
}
},
"ElementCreationOptions": {
"name": "ElementCreationOptions",
"exposed": "Window",
Expand Down
Loading