Skip to content

Change FileReader.readAsText‘s 2nd argument name #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Change FileReader.readAsText‘s 2nd argument name #536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ interface BiquadFilterOptions extends AudioNodeOptions {
}

interface BlobPropertyBag {
endings?: EndingType;
type?: string;
}

Expand Down Expand Up @@ -5013,7 +5014,7 @@ interface FileReader extends EventTarget {
readAsArrayBuffer(blob: Blob): void;
readAsBinaryString(blob: Blob): void;
readAsDataURL(blob: Blob): void;
readAsText(blob: Blob, label?: string): void;
readAsText(blob: Blob, encoding?: string): void;
readonly DONE: number;
readonly EMPTY: number;
readonly LOADING: number;
Expand Down Expand Up @@ -17653,6 +17654,7 @@ type DisplayCaptureSurfaceType = "monitor" | "window" | "application" | "browser
type DistanceModelType = "linear" | "inverse" | "exponential";
type DocumentReadyState = "loading" | "interactive" | "complete";
type EndOfStreamError = "network" | "decode";
type EndingType = "transparent" | "native";
type FillMode = "none" | "forwards" | "backwards" | "both" | "auto";
type GamepadHand = "" | "left" | "right";
type GamepadHapticActuatorType = "vibration";
Expand Down
6 changes: 4 additions & 2 deletions baselines/webworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ interface Algorithm {
}

interface BlobPropertyBag {
endings?: EndingType;
type?: string;
}

Expand Down Expand Up @@ -1197,7 +1198,7 @@ interface FileReader extends EventTarget {
readAsArrayBuffer(blob: Blob): void;
readAsBinaryString(blob: Blob): void;
readAsDataURL(blob: Blob): void;
readAsText(blob: Blob, label?: string): void;
readAsText(blob: Blob, encoding?: string): void;
readonly DONE: number;
readonly EMPTY: number;
readonly LOADING: number;
Expand All @@ -1219,7 +1220,7 @@ interface FileReaderSync {
readAsArrayBuffer(blob: Blob): ArrayBuffer;
readAsBinaryString(blob: Blob): string;
readAsDataURL(blob: Blob): string;
readAsText(blob: Blob, label?: string): string;
readAsText(blob: Blob, encoding?: string): string;
}

declare var FileReaderSync: {
Expand Down Expand Up @@ -2967,6 +2968,7 @@ type IDBValidKey = number | string | Date | BufferSource | IDBArrayKey;
type Transferable = ArrayBuffer | MessagePort | ImageBitmap;
type BinaryType = "blob" | "arraybuffer";
type ClientTypes = "window" | "worker" | "sharedworker" | "all";
type EndingType = "transparent" | "native";
type IDBCursorDirection = "next" | "nextunique" | "prev" | "prevunique";
type IDBRequestReadyState = "pending" | "done";
type IDBTransactionMode = "readonly" | "readwrite" | "versionchange";
Expand Down
7 changes: 5 additions & 2 deletions inputfiles/idl/File.widl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,11 @@ interface Blob {
optional DOMString contentType);
};

enum EndingType { "transparent", "native" };

dictionary BlobPropertyBag {
DOMString type = "";
EndingType endings = "transparent";
};

typedef (BufferSource or Blob or USVString) BlobPart;
Expand Down Expand Up @@ -43,7 +46,7 @@ interface FileReader: EventTarget {
// async read methods
void readAsArrayBuffer(Blob blob);
void readAsBinaryString(Blob blob);
void readAsText(Blob blob, optional DOMString label);
void readAsText(Blob blob, optional DOMString encoding);
void readAsDataURL(Blob blob);

void abort();
Expand Down Expand Up @@ -77,7 +80,7 @@ interface FileReaderSync {

ArrayBuffer readAsArrayBuffer(Blob blob);
DOMString readAsBinaryString(Blob blob);
DOMString readAsText(Blob blob, optional DOMString label);
DOMString readAsText(Blob blob, optional DOMString encoding);
DOMString readAsDataURL(Blob blob);
};

Expand Down
2 changes: 1 addition & 1 deletion inputfiles/idlSources.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"title": "Encoding"
},
{
"url": "https://www.w3.org/TR/FileAPI/",
"url": "https://w3c.github.io/FileAPI/",
"title": "File"
},
{
Expand Down