Skip to content

Changed returned type of Element.getElementsByClassName to HTMLCollectionOf<Element> #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2018
Merged

Changed returned type of Element.getElementsByClassName to HTMLCollectionOf<Element> #544

merged 1 commit into from
Aug 2, 2018

Conversation

timocov
Copy link
Contributor

@timocov timocov commented Jul 31, 2018

Fixes #543

@mhegazy
Copy link
Contributor

mhegazy commented Jul 31, 2018

@saschanaz can you please review this change.

saschanaz
saschanaz approved these changes Aug 1, 2018
View reviewed changes
Copy link
Contributor

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mhegazy mhegazy merged commit d0a51cd into microsoft:master Aug 2, 2018
@timocov timocov deleted the fix543 branch August 2, 2018 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschanaz saschanaz saschanaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timocov @mhegazy @saschanaz