Skip to content

Add types to key wrapping and unwrapping #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

JamesJansson
Copy link

@JamesJansson JamesJansson commented Jan 10, 2019

Currently, it is impossible to wrap and unwrap keys in Typescript as the algorithm parameters are not possible under the current type definitions. I have used the examples of wrap and unwrap from here:
https://developer.mozilla.org/en-US/docs/Web/API/SubtleCrypto/unwrapKey
https://developer.mozilla.org/en-US/docs/Web/API/SubtleCrypto/wrapKey

I may have gone overboard a little with including "RsaKeyAlgorithm | RsaHashedKeyAlgorithm" however the following assumes that those types are necessary:
https://github.com/diafygi/webcrypto-examples

closes #636

Currently, it is impossible to wrap and unwrap keys in Typescript as the algorithm parameters are not possible under the current type definitions. I have used the examples of wrap and unwrap from here:
https://developer.mozilla.org/en-US/docs/Web/API/SubtleCrypto/unwrapKey
https://developer.mozilla.org/en-US/docs/Web/API/SubtleCrypto/wrapKey

I may have gone overboard a little with including "RsaKeyAlgorithm | RsaHashedKeyAlgorithm" however the following assumes that those types are necessary:
https://github.com/diafygi/webcrypto-examples
@HolgerJeromin
Copy link
Contributor

If you add "closes #636" into your comment the issue will be closed on merge by the github infrastructure.

@sandersn
Copy link
Member

@JamesJansson looks like you need to run npm run baseline-accept to get tests to pass.

@msftclas
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ JamesJansson sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@orta
Copy link
Contributor

orta commented Feb 25, 2020

Hey @JamesJansson - we've looking through the backlog, I've updated the PR to master (and updated baselines) but we need both a CLA and the CI is failing. Any chance you can take a look at the CLA and give me an opinion on the CI?

@sandersn
Copy link
Member

This PR hasn't seen any activity for quite a while, so I'm going to close it to keep the number of open PRs manageable. Feel free to open a fresh PR or continue the discussion here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add types to key wrapping and unwrapping
5 participants