Skip to content

Make postMessage's 2nd param, targetOrigin, optional #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2019
Merged

Make postMessage's 2nd param, targetOrigin, optional #672

merged 1 commit into from
Apr 3, 2019

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented Apr 3, 2019

@sandersn sandersn merged commit 893e5ad into master Apr 3, 2019
@saschanaz
Copy link
Contributor

saschanaz commented Apr 4, 2019 •
edited
Loading

@sandersn This is wrong, it is a must.

https://developer.mozilla.org/en-US/docs/Web/API/Window/postMessage
https://html.spec.whatwg.org/multipage/window-object.html#the-window-object:dom-window-postmessage

@sandersn
Copy link
Member Author

sandersn commented Apr 4, 2019

Thanks for pointing that out @saschanaz. I got confused by the part of the spec linked from microsoft/TypeScript#30042 that references the options object, where targetOrigin is optional.

@sandersn
Copy link
Member Author

sandersn commented Apr 4, 2019

Reverted.

@sandersn sandersn deleted the make-postMessage-targetOrigin-parameter-optional branch April 4, 2019 16:48
@alewin alewin mentioned this pull request Mar 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandersn @saschanaz