Skip to content

Translation 3 files to Ko #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Oct 3, 2020
Merged

Translation 3 files to Ko #1116

merged 21 commits into from
Oct 3, 2020

Conversation

sodaMelon
Copy link
Contributor

@sodaMelon sodaMelon commented Sep 21, 2020 •
edited
Loading

en:

번역 리뷰 요청합니다! : @yeonjuan @guyeol @dvlprsh

ref: #910

  1. baseUrl.md : directory를 표준국어대사전 기준으로 디렉터리로 표기했습니다. 용어집에 따로 표기를 해두는게 좋을까요?
  2. charset.md : controlled을 일단 제어하다로 번역했는데, 어색한 것 같아서요...! 더 좋은 표현이 있다면 제안 부탁드립니다.
  3. Hello world.ts : 문장이 길어서, 자연스럽게 의미 전달 하는데 초점을 맞춰봤습니다. 더 좋은 표현이 있다면, 편하게 제안부탁드립니다(2)!! 😊

@ghost
Copy link

ghost commented Sep 21, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@github-actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @bumkeyy - if they write a comment saying "LGTM" then it will be merged.

@sodaMelon sodaMelon mentioned this pull request Sep 21, 2020
Closed
@bumkeyy
Copy link
Contributor

bumkeyy commented Sep 23, 2020 •
edited
Loading

playground는 플레이그라운드로 붙여쓰는게 어떨까요?

@sodaMelon
Copy link
Contributor Author

@bumkeyy 괜찮은 것 같아요 !!!
네이버 국어사전 play ground에서는 띄어쓰기를 하고있고 😥 다른 검색결과에서는 붙여쓰고 있어서 일단 그렇게 표기했었습니다. ㅎㅎ
이따 한국시간 18:00 PM 이후에 수정할게요!

@sodaMelon
Copy link
Contributor Author

고쳐뒀습니다~. 안바쁘실때 천천히 확인해주세요! 😇

@bumkeyy
Copy link
Contributor

bumkeyy commented Sep 30, 2020

고생하셨습니다 👍

  1. 디렉터리로 표기해주세요!
  2. 제어도 괜찮은 것 같아요.
  3. 의미가 퇴색되지 않은 정도에서 읽기 편하게 번역해주시면 좋을 것 같아요 :)

감사합니다.

sodaMelon and others added 17 commits September 30, 2020 17:31
@sodaMelon @bumkeyy
Update packages/playground-examples/copy/ko/JavaScript/JavaScript Ess…
bbb2b47 
…entials/Hello World.ts

Co-authored-by: Kibeom Kwon <[email protected]>
@sodaMelon @bumkeyy
Update packages/playground-examples/copy/ko/JavaScript/JavaScript Ess…
c2793d6 
…entials/Hello World.ts

Co-authored-by: Kibeom Kwon <[email protected]>
@sodaMelon @bumkeyy
Update packages/playground-examples/copy/ko/JavaScript/JavaScript Ess…
b3e98b0 
…entials/Hello World.ts

Co-authored-by: Kibeom Kwon <[email protected]>
@sodaMelon @bumkeyy
Update packages/playground-examples/copy/ko/JavaScript/JavaScript Ess…
155c516 
…entials/Hello World.ts

Co-authored-by: Kibeom Kwon <[email protected]>
@sodaMelon @bumkeyy
Update packages/playground-examples/copy/ko/JavaScript/JavaScript Ess…
91223fd 
…entials/Hello World.ts

Co-authored-by: Kibeom Kwon <[email protected]>
@sodaMelon @bumkeyy
Update packages/playground-examples/copy/ko/JavaScript/JavaScript Ess…
3c56b3c 
…entials/Hello World.ts

Co-authored-by: Kibeom Kwon <[email protected]>
@sodaMelon @bumkeyy
Update packages/playground-examples/copy/ko/JavaScript/JavaScript Ess…
cffbbc4 
…entials/Hello World.ts

Co-authored-by: Kibeom Kwon <[email protected]>
@sodaMelon @bumkeyy
Update packages/playground-examples/copy/ko/JavaScript/JavaScript Ess…
eda6c8a 
…entials/Hello World.ts

Co-authored-by: Kibeom Kwon <[email protected]>
@sodaMelon @bumkeyy
Update packages/playground-examples/copy/ko/JavaScript/JavaScript Ess…
f1f575e 
…entials/Hello World.ts

Co-authored-by: Kibeom Kwon <[email protected]>
@sodaMelon @bumkeyy
Update packages/playground-examples/copy/ko/JavaScript/JavaScript Ess…
8d39373 
…entials/Hello World.ts

Co-authored-by: Kibeom Kwon <[email protected]>
@sodaMelon @bumkeyy
Update packages/playground-examples/copy/ko/JavaScript/JavaScript Ess…
7802c0c 
…entials/Hello World.ts

Co-authored-by: Kibeom Kwon <[email protected]>
@sodaMelon @bumkeyy
Update packages/playground-examples/copy/ko/JavaScript/JavaScript Ess…
17ecd63 
…entials/Hello World.ts

Co-authored-by: Kibeom Kwon <[email protected]>
@sodaMelon @bumkeyy
Update packages/playground-examples/copy/ko/JavaScript/JavaScript Ess…
bbf574f 
…entials/Hello World.ts

Co-authored-by: Kibeom Kwon <[email protected]>
@sodaMelon @bumkeyy
Update packages/playground-examples/copy/ko/JavaScript/JavaScript Ess…
2998468 
…entials/Hello World.ts

Co-authored-by: Kibeom Kwon <[email protected]>
@sodaMelon @bumkeyy
Update packages/tsconfig-reference/copy/ko/options/baseUrl.md
3c81a7a 
Co-authored-by: Kibeom Kwon <[email protected]>
@sodaMelon @bumkeyy
Update packages/tsconfig-reference/copy/ko/options/charset.md
6934566 
Co-authored-by: Kibeom Kwon <[email protected]>
@sodaMelon @bumkeyy
Update packages/tsconfig-reference/copy/ko/options/charset.md
89ad5bb 
Co-authored-by: Kibeom Kwon <[email protected]>
@sodaMelon
Copy link
Contributor Author

자세하고 꼼꼼한 리뷰 감사합니다!!
이런 종류의 번역은 처음 해봐서, 어색한 부분이 많았는데... 😂😂😂😂
너무 고생 많으셨습니다...!!
제안해주셨던 사항들 전부 반영했습니다!

(추신: 용어집에 새로 고려 할 사항은 vanilla javascript, directory 정도인 것 같은데.... 저는 수정 권한?이 없기도 하고, 담당자분 판단하에 선택부탁드려요~)

즐거운 추석되세요!

@bumkeyy
Copy link
Contributor

bumkeyy commented Oct 3, 2020

LGTM

@github-actions github-actions bot merged commit 924f7dd into microsoft:v2 Oct 3, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2020

Merging because @bumkeyy is a code-owner of all the changes - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bumkeyy bumkeyy bumkeyy left review comments

Assignees
No one assigned
Labels
ko translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sodaMelon @bumkeyy